All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Cc: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	Tvrtko Ursulin <tvrtko.ursulin@igalia.com>,
	Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH] drm/i915/display: enable ccs modifiers on dg2
Date: Thu, 23 Apr 2026 13:45:56 +0300	[thread overview]
Message-ID: <aen4ZC9bY2820Bz5@intel.com> (raw)
In-Reply-To: <20260423101739.2772745-1-juhapekka.heikkila@gmail.com>

On Thu, Apr 23, 2026 at 01:17:39PM +0300, Juha-Pekka Heikkila wrote:
> Since Xe driver aux ccs enablement dg2 ccs modifiers have been
> disabled on both Xe and i915 drivers. Here allow dg2 to use
> ccs again for framebuffers.

How did CI not catch this? Or did it?

> 
> Fixes: 6a99e91 ("drm/i915/display: Detect AuxCCS support via display parent interface")
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
>  drivers/gpu/drm/i915/i915_driver.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
> index d31819758f3d..7a73461d398a 100644
> --- a/drivers/gpu/drm/i915/i915_driver.c
> +++ b/drivers/gpu/drm/i915/i915_driver.c
> @@ -54,9 +54,11 @@
>  #include "display/intel_bw.h"
>  #include "display/intel_cdclk.h"
>  #include "display/intel_crtc.h"
> +#include "display/intel_display_core.h"
>  #include "display/intel_display_device.h"
>  #include "display/intel_display_driver.h"
>  #include "display/intel_display_power.h"
> +#include "display/intel_display_types.h"
>  #include "display/intel_dmc.h"
>  #include "display/intel_dp.h"
>  #include "display/intel_dpt.h"
> @@ -749,8 +751,9 @@ static void fence_priority_display(struct dma_fence *fence)
>  static bool has_auxccs(struct drm_device *drm)
>  {
>  	struct drm_i915_private *i915 = to_i915(drm);
> +	struct intel_display *display = i915->display;
>  
> -	return IS_GRAPHICS_VER(i915, 9, 12) ||
> +	return IS_DISPLAY_VER(display, 9, 12) ||
>  	       IS_ALDERLAKE_P(i915) ||
>  	       IS_METEORLAKE(i915);
>  }
> -- 
> 2.43.0

-- 
Ville Syrjälä
Intel

  parent reply	other threads:[~2026-04-23 10:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-23 10:17 [PATCH] drm/i915/display: enable ccs modifiers on dg2 Juha-Pekka Heikkila
2026-04-23 10:28 ` Jani Nikula
2026-04-23 11:15   ` Tvrtko Ursulin
2026-04-23 11:27     ` Ville Syrjälä
2026-04-23 20:42     ` Matt Roper
2026-04-23 10:45 ` Ville Syrjälä [this message]
2026-04-23 10:58 ` ✗ CI.checkpatch: warning for " Patchwork
2026-04-23 10:59 ` ✓ CI.KUnit: success " Patchwork
2026-04-23 11:05 ` ✓ i915.CI.BAT: " Patchwork
2026-04-23 11:48 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-23 15:39 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aen4ZC9bY2820Bz5@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=juhapekka.heikkila@gmail.com \
    --cc=tvrtko.ursulin@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.