From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2121F99351 for ; Thu, 23 Apr 2026 08:30:52 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFpRc-0001Z5-Sz; Thu, 23 Apr 2026 04:29:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFpRP-0001SN-JK for qemu-devel@nongnu.org; Thu, 23 Apr 2026 04:29:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFpRM-0000J6-65 for qemu-devel@nongnu.org; Thu, 23 Apr 2026 04:29:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776932975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Mos+bQcAEHj4K5a62X6yzjC0RCfrU5JRF/fU1KxjrCI=; b=ZNn+DU9tW1FOlXfCLHDzo4sbiIcnQyU+9w9UiDrWAL3/ZhXESH/v+hMQno+KHZnH/r5pS0 dRDYgPTRYXLzQ+0TpYaCFyaxJPGguUuJUIcww9OSFOhwR7+gaZSIqTfww+vyugxGsPQtTq L6XQIyl6sWym4oH35L3xJOShmnAiOdE= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-215-NYqn4XV2Nb2Bh1wjtMv4lw-1; Thu, 23 Apr 2026 04:29:33 -0400 X-MC-Unique: NYqn4XV2Nb2Bh1wjtMv4lw-1 X-Mimecast-MFC-AGG-ID: NYqn4XV2Nb2Bh1wjtMv4lw_1776932973 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B62061956050; Thu, 23 Apr 2026 08:29:32 +0000 (UTC) Received: from redhat.com (unknown [10.44.48.215]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9952E19560AB; Thu, 23 Apr 2026 08:29:31 +0000 (UTC) Date: Thu, 23 Apr 2026 10:29:29 +0200 From: Kevin Wolf To: Fabiano Rosas Cc: qemu-devel@nongnu.org Subject: Re: [PATCH v1] checkpatch: Allow spaces after all coroutine annotations Message-ID: References: <20260420191356.4439-1-farosas@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260420191356.4439-1-farosas@suse.de> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.129.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Am 20.04.2026 um 21:13 hat Fabiano Rosas geschrieben: > The coroutine annotations may be used in the declaration of function > pointers, which triggers checkpatch due to the space before the > parentheses. E.g: > > int coroutine_fn (*run)(Job *job, Error **errp); > ^ > The coroutine_fn annotation is already included in the list of terms > where spaces are allowed. Add the other coroutine annotations: > coroutine_mixed_fn and no_coroutine_fn. > > Signed-off-by: Fabiano Rosas Reviewed-by: Kevin Wolf