From: Lorenzo Stoakes <ljs@kernel.org>
To: Pedro Falcato <pfalcato@suse.de>
Cc: SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Vlastimil Babka <vbabka@kernel.org>,
David Hildenbrand <david@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>
Subject: Re: [PATCH] MAINTAINERS: fix regex pattern in CORE MM category
Date: Thu, 23 Apr 2026 11:12:35 +0100 [thread overview]
Message-ID: <aenwfb-6JPtnH9qS@lucifer> (raw)
In-Reply-To: <v6cqjcp3fdkmh7z7twu2onxvmybl4na4enbnpsjf6z3lklaphw@n7iqq4rbkytn>
On Thu, Apr 23, 2026 at 10:39:59AM +0100, Pedro Falcato wrote:
> On Wed, Apr 22, 2026 at 05:32:26PM -0700, SeongJae Park wrote:
> > On Wed, 22 Apr 2026 13:37:26 +0100 Pedro Falcato <pfalcato@suse.de> wrote:
> >
> > > The pattern "include/linux/page[-_]*" matches every file that starts with
> > > "page", because it's a regex and not a glob (so it has the meaning of
> > > include/linux/page + match [-_] 0+ times).
> > >
> > > Fix it up into a more regex-correct expression. Doing so reduces CC's
> > > drastically in patches that touch pagemap.h (which is maintained as part of
> > > PAGE CACHE).
> > >
> > > As a side-effect, move linux/pageblock-flags.h explicitly under PAGE
> > > ALLOCATOR.
> > >
> > > Link: https://lore.kernel.org/linux-mm/20260422005608.342028-1-fmayle@google.com/
> >
> > Just thinking loud. I was initially wondering the purpose of this link. Seems
> > this was added to show the example of pagemap.h touching patch that can
> > dmonstrate how many CC can be reduced. I once thought about suggesting to add
> > the number or the context on the description, but realize it is too trivial.
> > So just thinking loud.
>
> Right, I probably chucked that link in there without explaining it well
> enough. I was having my leasurely read through linux-mm when I noticed that
> particular patch had _way_ too many CC's. I had a quick look and, yeah, found
> the issue.
>
> For what it's worth there are many such CC's out there. A group of 6-8 MM people
> get CC'd on pretty much everything that happens in the kernel. Not super wieldy.
>
> One thing at a time, I guess.
Yup this is a useful addition, the link is fine one thing at a time indeed :)
>
> >
> > $ # Without this patch
> > $ ./scripts/get_maintainer.pl ./0001-mm-limit-filemap-fault-readahead-to-vma-boundaries.patch | wc -l
> > 13
> > $ # With this patch
> > $ ./scripts/get_maintainer.pl ./0001-mm-limit-filemap-fault-readahead-to-vma-boundaries.patch | wc -l
> > 6
> >
> > > Signed-off-by: Pedro Falcato <pfalcato@suse.de>
> >
> > Reviewed-by: SeongJae Park <sj@kernel.org>
>
> Thanks!
>
> --
> Pedro
Cheers, Lorenzo
next prev parent reply other threads:[~2026-04-23 10:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 12:37 [PATCH] MAINTAINERS: fix regex pattern in CORE MM category Pedro Falcato
2026-04-22 12:45 ` Lorenzo Stoakes
2026-04-22 15:43 ` David Hildenbrand (Arm)
2026-04-22 16:40 ` Vlastimil Babka (SUSE)
2026-04-23 0:32 ` SeongJae Park
2026-04-23 9:39 ` Pedro Falcato
2026-04-23 10:12 ` Lorenzo Stoakes [this message]
2026-05-05 10:56 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aenwfb-6JPtnH9qS@lucifer \
--to=ljs@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=pfalcato@suse.de \
--cc=rppt@kernel.org \
--cc=sj@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.