From: Peter Xu <peterx@redhat.com>
To: Arun Menon <armenon@redhat.com>
Cc: qemu-devel@nongnu.org, "Fabiano Rosas" <farosas@suse.de>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH v3 1/2] migration/vmstate: Add VMState support for GByteArray
Date: Thu, 23 Apr 2026 11:34:21 -0400 [thread overview]
Message-ID: <aeo7_YcGk51EeCzJ@x1.local> (raw)
In-Reply-To: <aenKIbkSOjjGkg62@fedora>
On Thu, Apr 23, 2026 at 12:58:33PM +0530, Arun Menon wrote:
> Regarding the assert(), Would you like me to remove the
> explicit assert() in put_g_byte_array() as well? Since it is immediately
> followed by a dereference:
>
> qemu_put_be32(f, byte_array->len);
Your new version looks good, thanks.
--
Peter Xu
next prev parent reply other threads:[~2026-04-23 15:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 8:22 [PATCH v3 0/2] migration/vmstate: Add VMState support to safely migrate GByteArray Arun Menon
2026-04-22 8:22 ` [PATCH v3 1/2] migration/vmstate: Add VMState support for GByteArray Arun Menon
2026-04-22 19:58 ` Peter Xu
2026-04-23 7:28 ` Arun Menon
2026-04-23 15:34 ` Peter Xu [this message]
2026-04-22 8:22 ` [PATCH v3 2/2] ui/vdagent: Use VMSTATE_GBYTEARRAY to safely migrate outbuf Arun Menon
2026-04-22 19:59 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeo7_YcGk51EeCzJ@x1.local \
--to=peterx@redhat.com \
--cc=armenon@redhat.com \
--cc=farosas@suse.de \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.