All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Fernando Fernandez Mancera <fmancera@suse.de>
Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	jeremy@azazel.net, phil@nwl.cc, pablo@netfilter.org
Subject: Re: [PATCH nf v2] netfilter: nft_bitwise: fix dst corruption in same register shifts
Date: Thu, 23 Apr 2026 14:38:14 +0200	[thread overview]
Message-ID: <aeoStjrp12qNUeDL@strlen.de> (raw)
In-Reply-To: <684ec011-3785-4df4-a9ee-457025dcd447@suse.de>

Fernando Fernandez Mancera <fmancera@suse.de> wrote:
> On 4/23/26 2:27 PM, Florian Westphal wrote:
> > We should support overlaps (src == dst).  But partial overlaps?
> > Does nft generate such byte code?
> > 
> 
> No, not at all.

Phew. :-)

> Fine for me. I could not find any situation where this could be useful 
> but I was afraid of breaking some weird setups. If we have agreement 
> that this isn't useful I am fine rejecting it from control plane with 
> something like (not tested):

Lets wait for Pablos take on this, but I would prefer reject from
control plane.

  reply	other threads:[~2026-04-23 12:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-23 12:05 [PATCH nf v2] netfilter: nft_bitwise: fix dst corruption in same register shifts Fernando Fernandez Mancera
2026-04-23 12:27 ` Florian Westphal
2026-04-23 12:34   ` Fernando Fernandez Mancera
2026-04-23 12:38     ` Florian Westphal [this message]
2026-04-23 14:49       ` Pablo Neira Ayuso
2026-04-23 14:50         ` Fernando Fernandez Mancera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aeoStjrp12qNUeDL@strlen.de \
    --to=fw@strlen.de \
    --cc=coreteam@netfilter.org \
    --cc=fmancera@suse.de \
    --cc=jeremy@azazel.net \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.