From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Li Zhijian" <lizhijian@fujitsu.com>,
"Fabiano Rosas" <farosas@suse.de>,
"Zhang Chen" <zhangckid@gmail.com>,
"Juraj Marcin" <jmarcin@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>
Subject: Re: [PATCH 3/3] qio: Fix qom-list-properties crash on net listener object
Date: Thu, 23 Apr 2026 20:34:06 +0100 [thread overview]
Message-ID: <aep0Lga4YVvLWFTe@redhat.com> (raw)
In-Reply-To: <20260423183212.468047-4-peterx@redhat.com>
On Thu, Apr 23, 2026 at 02:32:12PM -0400, Peter Xu wrote:
> The QIO net listener object will crash with raw object_new() then
> dereference the object, like what QMP command qom-list-properties would do.
> Fix it by moving mutex init into instance_init().
>
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> Link: https://lore.kernel.org/r/87a4uvw066.fsf@pond.sub.org
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> io/net-listener.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
next prev parent reply other threads:[~2026-04-23 19:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 18:32 [PATCH 0/3] Three small fixes over qom-list-properties crash Peter Xu
2026-04-23 18:32 ` [PATCH 1/3] colo-compare: Fix QMP qom-list-properties crashing Peter Xu
2026-04-23 18:32 ` [PATCH 2/3] system/ioport: Fix qom-list-properties crash on portio list obj Peter Xu
2026-04-23 18:32 ` [PATCH 3/3] qio: Fix qom-list-properties crash on net listener object Peter Xu
2026-04-23 19:34 ` Daniel P. Berrangé [this message]
2026-04-24 7:01 ` [PATCH 0/3] Three small fixes over qom-list-properties crash Markus Armbruster
2026-04-28 15:36 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aep0Lga4YVvLWFTe@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=farosas@suse.de \
--cc=jasowang@redhat.com \
--cc=jmarcin@redhat.com \
--cc=lizhijian@fujitsu.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=zhangckid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.