All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Ramesh Adhikari <adhikari.resume@gmail.com>,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 0/1] netfilter: nfnetlink_queue: fix missing padding in NFQA_PAYLOAD attribute
Date: Thu, 23 Apr 2026 21:22:23 +0200	[thread overview]
Message-ID: <aepxb7oWbcjAvxZ8@strlen.de> (raw)
In-Reply-To: <aeoHL2ODYU6Xt28h@chamomile>

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Thu, Apr 23, 2026 at 04:54:35PM +0530, Ramesh Adhikari wrote:
> > IMPACT:
> > Correctness issue - violates netlink protocol. Could cause userspace
> > parsers to misparse or crash if they don't check message boundaries.
> 
> I see no issue at all here.

Me neither.  Userspace parsers cannot call 'nla_next()' unconditionally
as they might be looking at the last attribute.

NFQA_PAYLOAD is always the last attribute in the nfqueue message, due
to skb_zerocopy trick. Existing code is correct, and nla_len must be
the exact size: its end also is the end of the buffer/message.

  reply	other threads:[~2026-04-23 19:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAC-THR9QmgG9Vnhjw0YQUE=YSZ8GuPi7HbSKW_YA1FnUkDzQOA@mail.gmail.com>
2026-04-23 11:49 ` [PATCH 0/1] netfilter: nfnetlink_queue: fix missing padding in NFQA_PAYLOAD attribute Pablo Neira Ayuso
2026-04-23 19:22   ` Florian Westphal [this message]
2026-04-23 11:29 Ramesh Adhikari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aepxb7oWbcjAvxZ8@strlen.de \
    --to=fw@strlen.de \
    --cc=adhikari.resume@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.