From: Richard Cheng <icheng@nvidia.com>
To: Tejun Heo <tj@kernel.org>
Cc: Cheng-Yang Chou <yphbchou0911@gmail.com>,
arighi@nvidia.com, mingo@redhat.com, peterz@infradead.org,
void@manifault.com, changwoo@igalia.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
vschneid@redhat.com, sched-ext@lists.linux.dev,
linux-kernel@vger.kernel.org, newtonl@nvidia.com,
kristinc@nvidia.com, kaihengf@nvidia.com, kobak@nvidia.com,
Ching-Chun Huang <jserv@ccns.ncku.edu.tw>,
Chia-Ping Tsai <chia7712@gmail.com>
Subject: Re: [PATCH] sched_ext: sync disable_irq_work in bpf_scx_unreg()
Date: Fri, 24 Apr 2026 11:31:49 +0800 [thread overview]
Message-ID: <aerjzptPlD7C4x_c@MWDK4CY14F> (raw)
In-Reply-To: <aekEN_dlewzVi-Hq@slm.duckdns.org>
On Wed, Apr 22, 2026 at 07:24:07AM +0800, Tejun Heo wrote:
> Hello,
>
> On Wed, Apr 22, 2026 at 06:51:13PM +0800, Cheng-Yang Chou wrote:
> > Also, scx_root_enable_workfn() has the same pattern in its error path:
> >
> > scx_error(sch, "scx_root_enable() failed (%d)", ret);
> > kthread_flush_work(&sch->disable_work);
>
> Yeah, can you please add a helper - e.g. flush_disable_work() - to package
> sync and flush and use that in both places?
Hello Tejun,
No problem I'll add this part in v2.
>
> > > + /*
> > > + * sch->disable_work might still not queued, causing kthread_flush_work()
> > > + * as a noop. Syncing the irq_work first is required to guarantee the
> >
> > Perhaps s/noop/no-op/? Though it's just a matter of taste. ^_^
>
> noop is used widely in the kernel. In general, I don't think we need this
> level of language policing.
>
> Thanks.
>
> --
> tejun
Thanks.
- Richard
next prev parent reply other threads:[~2026-04-24 3:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 10:09 [PATCH] sched_ext: sync disable_irq_work in bpf_scx_unreg() Richard Cheng
2026-04-22 10:46 ` Andrea Righi
2026-04-22 10:51 ` Cheng-Yang Chou
2026-04-22 17:24 ` Tejun Heo
2026-04-24 3:31 ` Richard Cheng [this message]
2026-04-24 3:29 ` Richard Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aerjzptPlD7C4x_c@MWDK4CY14F \
--to=icheng@nvidia.com \
--cc=arighi@nvidia.com \
--cc=bsegall@google.com \
--cc=changwoo@igalia.com \
--cc=chia7712@gmail.com \
--cc=dietmar.eggemann@arm.com \
--cc=jserv@ccns.ncku.edu.tw \
--cc=juri.lelli@redhat.com \
--cc=kaihengf@nvidia.com \
--cc=kobak@nvidia.com \
--cc=kristinc@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=newtonl@nvidia.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sched-ext@lists.linux.dev \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=void@manifault.com \
--cc=vschneid@redhat.com \
--cc=yphbchou0911@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.