From: Robertus Diawan Chris <robertusdchris@gmail.com>
To: Dan Carpenter <error27@gmail.com>
Cc: andy@kernel.org, hansg@kernel.org, mchehab@kernel.org,
sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev,
linux-kernel-mentees@lists.linuxfoundation.org,
skhan@linuxfoundation.org, me@brighamcampbell.com
Subject: Re: [PATCH RFT] media: atomisp: Add error check in create_host_regular_capture_pipeline()
Date: Fri, 24 Apr 2026 12:47:58 +0700 [thread overview]
Message-ID: <aesEDiGBZiScCb0D@soyboi> (raw)
In-Reply-To: <aenHeWS4y8iLkMAn@stanley.mountain>
Hello Dan,
On Thu, Apr 23, 2026 at 10:17:13AM +0300, Dan Carpenter wrote:
> On Thu, Apr 23, 2026 at 01:02:46PM +0700, Robertus Diawan Chris wrote:
> > When calling ia_css_pipeline_create_and_add_stage() function, there's no
> > condition to check whether ia_css_pipeline_create_and_add_stage() throw
> > an error or not. So add conditional check for the return value of
> > ia_css_pipeline_create_and_add_stage() function.
> >
> > This is reported by Coverity Scan with CID 1408952 as UNUSED_VALUE.
> >
> > Signed-off-by: Robertus Diawan Chris <robertusdchris@gmail.com>
> > ---
>
> You need a Fixes tag.
Oh I didn't know that we need to add Fixes tag too. Alright, I will add
Fixes tag in the next iteration of the patch.
Thank you for the feedback.
Best regards,
Robertus Diawan Chris
prev parent reply other threads:[~2026-04-24 5:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 6:02 [PATCH RFT] media: atomisp: Add error check in create_host_regular_capture_pipeline() Robertus Diawan Chris
2026-04-23 7:17 ` Dan Carpenter
2026-04-24 5:47 ` Robertus Diawan Chris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aesEDiGBZiScCb0D@soyboi \
--to=robertusdchris@gmail.com \
--cc=andy@kernel.org \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=me@brighamcampbell.com \
--cc=sakari.ailus@linux.intel.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.