From: John Levon <john.levon@nutanix.com>
To: zhaoguohan@kylinos.cn
Cc: "Thanos Makatos" <thanos.makatos@nutanix.com>,
"Cédric Le Goater" <clg@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] vfio-user: reject malformed migration capabilities
Date: Fri, 24 Apr 2026 10:07:08 +0100 [thread overview]
Message-ID: <aesyvEr6_HDsl1ML@lent> (raw)
In-Reply-To: <20260424031259.289211-1-zhaoguohan@kylinos.cn>
On Fri, Apr 24, 2026 at 11:12:59AM +0800, zhaoguohan@kylinos.cn wrote:
> check_migr() sets an error when the migration capability is not an object,
> but still returns true. This lets version negotiation continue with an
> Error set and reports the wrong capability name in the diagnostic.
>
> Return false for the malformed capability, and report the migration
> capability name.
>
> Fixes: 36227628d824 ("vfio-user: implement message send infrastructure")
> Signed-off-by: GuoHan Zhao <zhaoguohan@kylinos.cn>
Thanks!
Reviewed-by: John Levon <john.levon@nutanix.com>
regards
john
next prev parent reply other threads:[~2026-04-24 9:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-24 3:12 [PATCH] vfio-user: reject malformed migration capabilities zhaoguohan
2026-04-24 9:07 ` John Levon [this message]
2026-05-04 15:03 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aesyvEr6_HDsl1ML@lent \
--to=john.levon@nutanix.com \
--cc=clg@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thanos.makatos@nutanix.com \
--cc=zhaoguohan@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.