From: Nicolin Chen <nicolinc@nvidia.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: <will@kernel.org>, <robin.murphy@arm.com>, <kevin.tian@intel.com>,
<joro@8bytes.org>, <praan@google.com>, <baolu.lu@linux.intel.com>,
<miko.lenczewski@arm.com>, <smostafa@google.com>,
<linux-arm-kernel@lists.infradead.org>, <iommu@lists.linux.dev>,
<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>,
<jamien@nvidia.com>
Subject: Re: [PATCH rc v2 1/5] iommu/arm-smmu-v3: Add arm_smmu_adopt_strtab() for kdump
Date: Fri, 24 Apr 2026 11:33:16 -0700 [thread overview]
Message-ID: <aeu3bNxCsy8azLOO@Asurada-Nvidia> (raw)
In-Reply-To: <20260424165613.GC3444440@nvidia.com>
On Fri, Apr 24, 2026 at 01:56:13PM -0300, Jason Gunthorpe wrote:
> On Wed, Apr 15, 2026 at 02:17:36PM -0700, Nicolin Chen wrote:
> > +static int arm_smmu_adopt_strtab_2lvl(struct arm_smmu_device *smmu, u32 cfg_reg,
[..]
> > + cfg->l2.l1tab = devm_memremap(
> > + smmu->dev, dma, num_l1_ents * sizeof(struct arm_smmu_strtab_l1),
> > + MEMREMAP_WB);
>
> WB shouldn't be unconditional? If the SMMU is working non-coherently
> we need to map it NC. Same remark everwhere
Hmm, I am trying to add a coherent-only gate for the series.
MEMREMAP_WC might work. But we cannot verify that on a coherent
SMMU, right?
Nicolin
next prev parent reply other threads:[~2026-04-24 18:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 21:17 [PATCH rc v2 0/5] iommu/arm-smmu-v3: Fix device crash on kdump kernel Nicolin Chen
2026-04-15 21:17 ` [PATCH rc v2 1/5] iommu/arm-smmu-v3: Add arm_smmu_adopt_strtab() for kdump Nicolin Chen
2026-04-24 16:56 ` Jason Gunthorpe
2026-04-24 18:33 ` Nicolin Chen [this message]
2026-04-24 20:50 ` Jason Gunthorpe
2026-04-25 0:56 ` Nicolin Chen
2026-04-15 21:17 ` [PATCH rc v2 2/5] iommu/arm-smmu-v3: Implement is_attach_deferred() " Nicolin Chen
2026-04-24 16:59 ` Jason Gunthorpe
2026-04-24 18:44 ` Nicolin Chen
2026-04-24 20:51 ` Jason Gunthorpe
2026-04-15 21:17 ` [PATCH rc v2 3/5] iommu/arm-smmu-v3: Retain CR0_SMMUEN during kdump device reset Nicolin Chen
2026-04-15 21:17 ` [PATCH rc v2 4/5] iommu/arm-smmu-v3: Skip EVTQ/PRIQ setup in kdump kernel Nicolin Chen
2026-04-15 21:17 ` [PATCH rc v2 5/5] iommu/arm-smmu-v3: Detect ARM_SMMU_OPT_KDUMP in arm_smmu_device_hw_probe() Nicolin Chen
2026-04-16 16:49 ` [PATCH rc v2 0/5] iommu/arm-smmu-v3: Fix device crash on kdump kernel Robin Murphy
2026-04-16 17:20 ` Jason Gunthorpe
2026-04-17 7:48 ` Tian, Kevin
2026-04-17 11:59 ` Jason Gunthorpe
2026-04-23 20:02 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeu3bNxCsy8azLOO@Asurada-Nvidia \
--to=nicolinc@nvidia.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jamien@nvidia.com \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miko.lenczewski@arm.com \
--cc=praan@google.com \
--cc=robin.murphy@arm.com \
--cc=smostafa@google.com \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.