All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: Angelo Dureghello <angelo@kernel-space.org>
Cc: trini@konsulko.com, u-boot@lists.denx.de, sjg@chromium.org
Subject: Re: [PATCH 5/9] configs: stmark2: add support for mmc
Date: Sun, 26 Apr 2026 01:02:20 +0800	[thread overview]
Message-ID: <aezznOpfVei-LZF8@google.com> (raw)
In-Reply-To: <20260416121431.20852-5-angelo@kernel-space.org>

Hi Angelo,

On Thu, Apr 16, 2026 at 02:14:27PM +0200, Angelo Dureghello wrote:
> Add support for mmc.
> 
> Signed-off-by: Angelo Dureghello <angelo@kernel-space.org>

it looks like the changes to stmark2_defconfig were edited manually.
Could you please use make savedefconfig to generate this file?

Regards,
Kuan-Wei

$ make stmark2_defconfig
$ make savedefconfig
$ diff -u configs/stmark2_defconfig defconfig
--- configs/stmark2_defconfig   2026-04-25 17:01:03.607521115 +0000
+++ defconfig   2026-04-25 17:01:11.186044050 +0000
@@ -28,18 +28,17 @@
 # CONFIG_CMD_IMPORTENV is not set
 CONFIG_CMD_I2C=y
 # CONFIG_CMD_LOADS is not set
+CONFIG_CMD_MMC=y
 CONFIG_CMD_SPI=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_CACHE=y
-CONFIG_CMD_MTDPARTS=y
-CONFIG_MTDIDS_DEFAULT="nor0=spi-flash.0"
-CONFIG_MTDPARTS_DEFAULT="mtdparts=spi-flash.0:1m(u-boot),7m(kernel),-(rootfs)"
-CONFIG_CMD_MMC=y
 CONFIG_CMD_EXT2=y
 CONFIG_CMD_EXT4=y
 CONFIG_CMD_FAT=y
 CONFIG_CMD_FS_GENERIC=y
-CONFIG_DOS_PARTITION=y
+CONFIG_CMD_MTDPARTS=y
+CONFIG_MTDIDS_DEFAULT="nor0=spi-flash.0"
+CONFIG_MTDPARTS_DEFAULT="mtdparts=spi-flash.0:1m(u-boot),7m(kernel),-(rootfs)"
 CONFIG_ENV_IS_IN_SPI_FLASH=y
 CONFIG_ENV_SPI_CS=1
 CONFIG_ENV_RELOC_GD_ENV_ADDR=y
@@ -48,9 +47,8 @@
 CONFIG_NO_NET=y
 CONFIG_DM_I2C=y
 CONFIG_SYS_I2C_FSL=y
-CONFIG_MTD=y
 CONFIG_MMC=y
-CONFIG_FSL_ESDHC_IMX=y
+CONFIG_MTD=y
 CONFIG_DM_SPI_FLASH=y
 CONFIG_SPI_FLASH_ISSI=y
 CONFIG_SPI_FLASH_MTD=y

> ---
>  configs/stmark2_defconfig | 18 +++++++++++++-----
>  1 file changed, 13 insertions(+), 5 deletions(-)
> 
> diff --git a/configs/stmark2_defconfig b/configs/stmark2_defconfig
> index ae1fa34df2a..763cbac158d 100644
> --- a/configs/stmark2_defconfig
> +++ b/configs/stmark2_defconfig
> @@ -3,19 +3,19 @@ CONFIG_TEXT_BASE=0x47E00000
>  CONFIG_SYS_MALLOC_LEN=0x40000
>  CONFIG_SF_DEFAULT_SPEED=50000000
>  CONFIG_ENV_SIZE=0x2000
> -CONFIG_ENV_OFFSET=0x40000
> +CONFIG_ENV_OFFSET=0x80000
>  CONFIG_ENV_SECT_SIZE=0x10000
>  CONFIG_DEFAULT_DEVICE_TREE="stmark2"
> -CONFIG_SYS_MONITOR_LEN=262144
> -CONFIG_SYS_LOAD_ADDR=0x40010000
> +CONFIG_SYS_MONITOR_LEN=327680
> +CONFIG_SYS_LOAD_ADDR=0x42000000
>  CONFIG_TARGET_STMARK2=y
>  CONFIG_SYS_BARGSIZE=256
>  CONFIG_SYS_MONITOR_BASE=0x47E00400
>  CONFIG_TIMESTAMP=y
>  CONFIG_USE_BOOTARGS=y
> -CONFIG_BOOTARGS="console=ttyS0,115200 root=/dev/ram0 rw rootfstype=ramfs rdinit=/bin/init devtmpfs.mount=1"
> +CONFIG_BOOTARGS="console=ttyS0,115200 root=/dev/ram0 rw rootfstype=ramfs rdinit=/sbin/init devtmpfs.mount=1"
>  CONFIG_USE_BOOTCOMMAND=y
> -CONFIG_BOOTCOMMAND="sf probe 0:1 50000000; sf read ${loadaddr} 0x100000 ${kern_size}; bootm ${loadaddr}"
> +CONFIG_BOOTCOMMAND="run boot_sd; bootm ${loadaddr} ${loadaddr_ramfs}"
>  CONFIG_SYS_PBSIZE=283
>  # CONFIG_DISPLAY_BOARDINFO is not set
>  CONFIG_SYS_MALLOC_BOOTPARAMS=y
> @@ -34,6 +34,12 @@ CONFIG_CMD_CACHE=y
>  CONFIG_CMD_MTDPARTS=y
>  CONFIG_MTDIDS_DEFAULT="nor0=spi-flash.0"
>  CONFIG_MTDPARTS_DEFAULT="mtdparts=spi-flash.0:1m(u-boot),7m(kernel),-(rootfs)"
> +CONFIG_CMD_MMC=y
> +CONFIG_CMD_EXT2=y
> +CONFIG_CMD_EXT4=y
> +CONFIG_CMD_FAT=y
> +CONFIG_CMD_FS_GENERIC=y
> +CONFIG_DOS_PARTITION=y
>  CONFIG_ENV_IS_IN_SPI_FLASH=y
>  CONFIG_ENV_SPI_CS=1
>  CONFIG_ENV_RELOC_GD_ENV_ADDR=y
> @@ -43,6 +49,8 @@ CONFIG_NO_NET=y
>  CONFIG_DM_I2C=y
>  CONFIG_SYS_I2C_FSL=y
>  CONFIG_MTD=y
> +CONFIG_MMC=y
> +CONFIG_FSL_ESDHC_IMX=y
>  CONFIG_DM_SPI_FLASH=y
>  CONFIG_SPI_FLASH_ISSI=y
>  CONFIG_SPI_FLASH_MTD=y
> -- 
> 2.53.0
> 

  reply	other threads:[~2026-04-25 17:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-16 12:14 [PATCH 1/9] m68k: dts: mcf5441x: add mmc device for mcf5441x Angelo Dureghello
2026-04-16 12:14 ` [PATCH 2/9] m68k: dts: stmark2: enable esdhc Angelo Dureghello
2026-04-16 12:14 ` [PATCH 3/9] board: stmark2: add sd boot command Angelo Dureghello
2026-04-16 12:14 ` [PATCH 4/9] board: stmark2: remove old garbage Angelo Dureghello
2026-04-25 16:26   ` Kuan-Wei Chiu
2026-04-25 16:31     ` Kuan-Wei Chiu
2026-04-16 12:14 ` [PATCH 5/9] configs: stmark2: add support for mmc Angelo Dureghello
2026-04-25 17:02   ` Kuan-Wei Chiu [this message]
2026-04-16 12:14 ` [PATCH 6/9] configs: stmark2: add bdinfo command Angelo Dureghello
2026-04-16 12:14 ` [PATCH 7/9] mmc: Kconfig: allows m68k to use esdhc imx driver Angelo Dureghello
2026-04-16 12:14 ` [PATCH 8/9] m68k: mcf5441x: create stub to use imx drivers Angelo Dureghello
2026-04-16 12:14 ` [PATCH 9/9] m68k: set proper u-boot image size for initial boot Angelo Dureghello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aezznOpfVei-LZF8@google.com \
    --to=visitorckw@gmail.com \
    --cc=angelo@kernel-space.org \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.