From: Andrea Righi <arighi@nvidia.com>
To: Tejun Heo <tj@kernel.org>
Cc: David Vernet <void@manifault.com>,
Changwoo Min <changwoo@igalia.com>,
Emil Tsalapatis <emil@etsalapatis.com>,
sched-ext@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH sched_ext/for-7.1-fixes] sched_ext: Fix !CONFIG_EXT_SUB_SCHED build warnings
Date: Fri, 8 May 2026 07:28:47 +0200 [thread overview]
Message-ID: <af10jxkI3joCq9-7@gpd4> (raw)
In-Reply-To: <20260508001652.3477646-1-tj@kernel.org>
Hi Tejun,
On Thu, May 07, 2026 at 02:16:52PM -1000, Tejun Heo wrote:
> W=1 with CONFIG_EXT_SUB_SCHED=n flags 'err_msg' uninitialized and
> 'err_free_lb_resched' unused. Initialize err_msg and gate the label.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
Reviewed-by: Andrea Righi <arighi@nvidia.com>
Maybe add also:
Fixes: d292aa00de1a ("sched_ext: Make bypass LB cpumasks per-scheduler")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202605080821.ftqLNrXX-lkp@intel.com/
Thanks,
-Andrea
> ---
> kernel/sched/ext.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c
> index 48b4834c7027..f4e2db8e56be 100644
> --- a/kernel/sched/ext.c
> +++ b/kernel/sched/ext.c
> @@ -5584,7 +5584,7 @@ static void refresh_watchdog(void)
>
> static s32 scx_link_sched(struct scx_sched *sch)
> {
> - const char *err_msg;
> + const char *err_msg = "";
> s32 ret = 0;
>
> scoped_guard(raw_spinlock_irq, &scx_sched_lock) {
> @@ -6652,8 +6652,10 @@ static struct scx_sched *scx_alloc_and_add_sched(struct sched_ext_ops *ops,
> #endif /* CONFIG_EXT_SUB_SCHED */
> return sch;
>
> +#ifdef CONFIG_EXT_SUB_SCHED
> err_free_lb_resched:
> free_cpumask_var(sch->bypass_lb_resched_cpumask);
> +#endif
> err_free_lb_cpumask:
> free_cpumask_var(sch->bypass_lb_donee_cpumask);
> err_stop_helper:
prev parent reply other threads:[~2026-05-08 5:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 0:16 [PATCH sched_ext/for-7.1-fixes] sched_ext: Fix !CONFIG_EXT_SUB_SCHED build warnings Tejun Heo
2026-05-08 0:20 ` Tejun Heo
2026-05-08 5:28 ` Andrea Righi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af10jxkI3joCq9-7@gpd4 \
--to=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=emil@etsalapatis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sched-ext@lists.linux.dev \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.