From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 986A2E95A96 for ; Mon, 9 Oct 2023 11:31:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346261AbjJILbz (ORCPT ); Mon, 9 Oct 2023 07:31:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234521AbjJILbm (ORCPT ); Mon, 9 Oct 2023 07:31:42 -0400 Received: from out-210.mta0.migadu.com (out-210.mta0.migadu.com [91.218.175.210]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F68710C4 for ; Mon, 9 Oct 2023 04:31:31 -0700 (PDT) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1696851089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ypvN2XpqA8dd13EXMeITEkp7Kaqjv9X9NOFxyBYPp0E=; b=xC/nJWFHMyG8w9XFZjH7wF8Hl9CFzSq+66CSaKoOUoIjbjGjLnnhDMlW2EnL/FXI4CwvWs xduNRs7Ju51Fx9nkkJydt7YH6J5eMosBTSW3Zd0V65pukXAlpUf0lTg7P8I0ozHYN5paKL x2l30tUdkI3RZAaEJS1rJMoJsCXrBco= Date: Mon, 9 Oct 2023 19:31:19 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 2/2] sched/rt: Move sched_rt_entity::back to under the CONFIG_RT_GROUP_SCHED block Content-Language: en-US To: Ingo Molnar Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, linux-kernel@vger.kernel.org References: <20231005162317.3343678-1-yajun.deng@linux.dev> <20231005162317.3343678-3-yajun.deng@linux.dev> <5a3342ef-f14f-173c-630f-6b474bded257@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yajun Deng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/10/9 19:26, Ingo Molnar wrote: > * Yajun Deng wrote: > >> On 2023/10/9 18:16, Ingo Molnar wrote: >>> * Yajun Deng wrote: >>> >>>> The member back in struct sched_rt_entity only related to RT_GROUP_SCHED, >>>> So move sched_rt_entity::back to under the CONFIG_RT_GROUP_SCHED block. It >>>> will save a few bytes. >>>> >>>> Also, init child when parent isn't NULL in init_tg_rt_entry(). >>>> >>>> Signed-off-by: Yajun Deng >>>> --- >>>> include/linux/sched.h | 2 +- >>>> kernel/sched/rt.c | 18 +++++++++--------- >>>> 2 files changed, 10 insertions(+), 10 deletions(-) >>>> >>>> diff --git a/include/linux/sched.h b/include/linux/sched.h >>>> index 292c31697248..d0fe56603e60 100644 >>>> --- a/include/linux/sched.h >>>> +++ b/include/linux/sched.h >>>> @@ -597,8 +597,8 @@ struct sched_rt_entity { >>>> unsigned short on_rq; >>>> unsigned short on_list; >>>> - struct sched_rt_entity *back; >>>> #ifdef CONFIG_RT_GROUP_SCHED >>>> + struct sched_rt_entity *back; >>>> struct sched_rt_entity *parent; >>>> /* rq on which this entity is (to be) queued: */ >>>> struct rt_rq *rt_rq; >>> Title claims this change - the rest of the changes should be in a separate >>> patch: >> >> Okay. I will send v2. > It's ~v7 already by my count, isn't it? May be. If we count from the earliest. > > Thanks, > > Ingo