From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7A02CD3436 for ; Fri, 8 May 2026 10:15:11 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wLIED-0005gO-SU; Fri, 08 May 2026 06:14:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wLIEC-0005gF-Vd for qemu-devel@nongnu.org; Fri, 08 May 2026 06:14:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wLIEA-0005uq-Ru for qemu-devel@nongnu.org; Fri, 08 May 2026 06:14:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778235277; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/2VBe3czOx2dlHXefHypozzJQxLuKLwyXOtlr2lJI1c=; b=cCj+251pJmsvivVxLi8HY2tm9pQ/Ryy6gjmlPek4Yor/uXLvTAGyUTXLk7/ESY7C85fyau P51oR6MvFlPKTu0b/jLP6GMFS+pKMWvBwSZExc2RCjfj9TpMdJePahYQ6gHetwPPkdBFaZ DImo8wpI2i4yso9Z4WsZBo0atjfzvmQ= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-ZakhmmzwOzmTwcKoKDbJJg-1; Fri, 08 May 2026 06:14:35 -0400 X-MC-Unique: ZakhmmzwOzmTwcKoKDbJJg-1 X-Mimecast-MFC-AGG-ID: ZakhmmzwOzmTwcKoKDbJJg_1778235274 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B8D2A18005B5 for ; Fri, 8 May 2026 10:14:34 +0000 (UTC) Received: from redhat.com (unknown [10.44.32.204]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8BD101803A93; Fri, 8 May 2026 10:14:33 +0000 (UTC) Date: Fri, 8 May 2026 11:14:30 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: qemu-devel@nongnu.org Subject: Re: [PATCH v3 02/26] char: error out if given unhandled size options Message-ID: References: <20260430-qemu-vnc-v3-0-be96757428d0@redhat.com> <20260430-qemu-vnc-v3-2-be96757428d0@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260430-qemu-vnc-v3-2-be96757428d0@redhat.com> User-Agent: Mutt/2.3.1 (2026-03-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.438, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Apr 30, 2026 at 01:02:35AM +0400, Marc-André Lureau wrote: > This is a small help, because in fact all combined chardev > options are accepted by qemu_chardev_opts[]. But given that a user may > legitimately want to use the size options with a VC backend, we can > report an error when we know the backend doesn't support it. > > Signed-off-by: Marc-André Lureau > --- > include/chardev/char.h | 1 + > include/qemu/option.h | 1 + > chardev/char.c | 12 ++++++++++++ > ui/console-vc.c | 1 + > util/qemu-option.c | 13 +++++++++++++ > 5 files changed, 28 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|