From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE8FCCD3447 for ; Fri, 8 May 2026 10:25:30 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wLIOJ-0002gc-6K; Fri, 08 May 2026 06:25:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wLIOH-0002gP-1l for qemu-devel@nongnu.org; Fri, 08 May 2026 06:25:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wLIOE-0007rk-AX for qemu-devel@nongnu.org; Fri, 08 May 2026 06:25:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778235900; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5HJJ4ytRhP/bi3IPPWp9EY7/jglSh7cbyjVPVhH/iBw=; b=KLxZaLH44SHo6Xd18PWPZp6rAu/I0peWMpbNFw10Zjt0sOLche9AnPptWp3/Ly+YELc9h7 rnbJ6zC5rRTwrUsqhUXP03zroPGqvrjfUyxWBCiVBFFHQ9gzvnGP0ZnV4qm8CSETJ4CK1p F+vSBIl5iiUwSuwycxrcK9E7QWvzyPU= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-241-Cxnr2xUvP2ee9M0DYFveMQ-1; Fri, 08 May 2026 06:24:58 -0400 X-MC-Unique: Cxnr2xUvP2ee9M0DYFveMQ-1 X-Mimecast-MFC-AGG-ID: Cxnr2xUvP2ee9M0DYFveMQ_1778235898 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 08A1D19560AA for ; Fri, 8 May 2026 10:24:58 +0000 (UTC) Received: from redhat.com (unknown [10.44.32.204]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D621F1800374; Fri, 8 May 2026 10:24:56 +0000 (UTC) Date: Fri, 8 May 2026 11:24:53 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: qemu-devel@nongnu.org Subject: Re: [PATCH v3 17/26] ui/vnc: clean up VNC displays on exit Message-ID: References: <20260430-qemu-vnc-v3-0-be96757428d0@redhat.com> <20260430-qemu-vnc-v3-17-be96757428d0@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260430-qemu-vnc-v3-17-be96757428d0@redhat.com> User-Agent: Mutt/2.3.1 (2026-03-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.438, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Apr 30, 2026 at 01:02:50AM +0400, Marc-André Lureau wrote: > Previously, VNC displays were never torn down on QEMU exit, leaking > resources and leaving connected clients with unclean disconnects. > > Add vnc_cleanup() to free all VNC displays during qemu_cleanup(). > Make vnc_display_close() initiate disconnection of active clients, > and have vnc_display_free() drain the main loop until all clients > have completed their teardown, instead of asserting the client list > is empty. > > Signed-off-by: Marc-André Lureau > --- > include/ui/console.h | 1 + > system/runstate.c | 5 +++++ > ui/vnc.c | 20 ++++++++++++++++++-- > 3 files changed, 24 insertions(+), 2 deletions(-) > Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|