From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC80CCD3436 for ; Fri, 8 May 2026 10:22:51 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wLIM1-0001tW-Ty; Fri, 08 May 2026 06:22:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wLILz-0001t7-U3 for qemu-devel@nongnu.org; Fri, 08 May 2026 06:22:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wLILy-0007We-9U for qemu-devel@nongnu.org; Fri, 08 May 2026 06:22:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778235761; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pbAR40Ymi5UG/M/E4p5Qn23nusjgIn4ibiIMYBNV7dc=; b=YzVvRa5DUSDd436pAT8fcHKtacqTviVRmzVdqFnYSXDn6Yt+9OXcn1T04NrsgufrVEqoIp RsLDy1gEp8Mj8EznU5tytfguG0R3ZB8zRNFvt2SJjkKJuofRdzL8hGsZS7h20hKAZYFpiT /EYkr7ncvD6phLo8Hpfvffr2Wm/n4M8= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-264-NM9rtV4PMOuW7MC74WABtg-1; Fri, 08 May 2026 06:22:40 -0400 X-MC-Unique: NM9rtV4PMOuW7MC74WABtg-1 X-Mimecast-MFC-AGG-ID: NM9rtV4PMOuW7MC74WABtg_1778235759 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1B646195608E for ; Fri, 8 May 2026 10:22:39 +0000 (UTC) Received: from redhat.com (unknown [10.44.32.204]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E94E6300019F; Fri, 8 May 2026 10:22:37 +0000 (UTC) Date: Fri, 8 May 2026 11:22:34 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: qemu-devel@nongnu.org Subject: Re: [PATCH v3 14/26] ui/vnc: make the worker thread per-VncDisplay Message-ID: References: <20260430-qemu-vnc-v3-0-be96757428d0@redhat.com> <20260430-qemu-vnc-v3-14-be96757428d0@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260430-qemu-vnc-v3-14-be96757428d0@redhat.com> User-Agent: Mutt/2.3.1 (2026-03-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.438, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Apr 30, 2026 at 01:02:47AM +0400, Marc-André Lureau wrote: > The VNC encoding worker thread was using a single global queue shared > across all VNC displays, with no way to stop it. This made it impossible > to properly clean up resources when a VncDisplay is freed. > > Move the VncJobQueue from a file-scoped global to a per-VncDisplay > member, so each display owns its worker thread and queue. Add > vnc_stop_worker_thread() to perform an orderly shutdown: signal the > thread to exit, join it, and destroy the queue. The thread is now > created as QEMU_THREAD_JOINABLE instead of QEMU_THREAD_DETACHED. > > Signed-off-by: Marc-André Lureau > --- > ui/vnc-jobs.h | 3 ++- > ui/vnc.h | 2 ++ > ui/vnc-jobs.c | 62 ++++++++++++++++++++++++++++++++++++++--------------------- > ui/vnc.c | 3 ++- > 4 files changed, 46 insertions(+), 24 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|