From: Thierry Reding <thierry.reding@kernel.org>
To: Saurav Sachidanand <sauravsc@amazon.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Akhil R <akhilrajeev@nvidia.com>,
Kartik Rajput <kkartik@nvidia.com>,
Thierry Reding <treding@nvidia.com>,
Jon Hunter <jonathanh@nvidia.com>,
linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] i2c: tegra: fix pm_runtime leak on mutex_lock failure
Date: Fri, 8 May 2026 12:24:33 +0200 [thread overview]
Message-ID: <af25yiUXoxiWFcIU@orome> (raw)
In-Reply-To: <20260507221145.62183-2-sauravsc@amazon.com>
[-- Attachment #1: Type: text/plain, Size: 673 bytes --]
On Thu, May 07, 2026 at 10:11:44PM +0000, Saurav Sachidanand wrote:
> If tegra_i2c_mutex_lock() fails, the function returns without calling
> pm_runtime_put(), leaking the runtime PM reference acquired by the
> preceding pm_runtime_get_sync(). This prevents the device from ever
> entering runtime suspend.
>
> Add the missing pm_runtime_put() before returning on lock failure.
>
> Fixes: 6077cfd716fb ("i2c: tegra: Add support for SW mutex register")
> Signed-off-by: Saurav Sachidanand <sauravsc@amazon.com>
> ---
> drivers/i2c/busses/i2c-tegra.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-05-08 10:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 19:53 [PATCH 1/1] i2c: tegra: fix error handling in tegra_i2c_xfer() Saurav Sachidanand
2026-05-07 7:23 ` Jon Hunter
2026-05-07 22:11 ` [PATCH v2 0/2] " Saurav Sachidanand
2026-05-07 22:11 ` [PATCH v2 1/2] i2c: tegra: fix pm_runtime leak on mutex_lock failure Saurav Sachidanand
2026-05-08 10:24 ` Thierry Reding [this message]
2026-05-08 15:13 ` Jon Hunter
2026-05-07 22:11 ` [PATCH v2 2/2] i2c: tegra: make tegra_i2c_mutex_unlock() return void Saurav Sachidanand
2026-05-08 10:24 ` Thierry Reding
2026-05-08 15:14 ` Jon Hunter
2026-05-13 22:24 ` [PATCH v2 0/2] i2c: tegra: fix error handling in tegra_i2c_xfer() Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af25yiUXoxiWFcIU@orome \
--to=thierry.reding@kernel.org \
--cc=akhilrajeev@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kkartik@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=sauravsc@amazon.com \
--cc=treding@nvidia.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.