From: Phil Sutter <phil@nwl.cc>
To: Florian Westphal <fw@strlen.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] scanner: Accept all statements' first words in all scopes
Date: Fri, 8 May 2026 12:28:52 +0200 [thread overview]
Message-ID: <af265E0SP78KxmpQ@orbyte.nwl.cc> (raw)
In-Reply-To: <af25GqQQQXt8pZhf@orbyte.nwl.cc>
On Fri, May 08, 2026 at 12:21:14PM +0200, Phil Sutter wrote:
> On Fri, May 08, 2026 at 12:04:19AM +0200, Florian Westphal wrote:
[...]
> > > -"limit" { scanner_push_start_cond(yyscanner, SCANSTATE_LIMIT); return LIMIT; }
> > > +<*>"limit" { scanner_push_start_cond(yyscanner, SCANSTATE_LIMIT); return LIMIT; }
> >
> > limit limit?
>
> Heh, that is indeed a bug. Aside from the questionable semantics, LIMIT
> token is obviously accepted in SCANSTATE_LIMIT already.
That is not true: The exclusive start condition is SCANSTATE_RATE, not
_LIMIT. So "limit <foo> limit <bar>" is not accepted without this, and
if my approach at ignoring semantics (and keeping the possibility for
more exclusive start conditions in mind) is OK, I'd rather not drop this
change.
Cheers, Phil
prev parent reply other threads:[~2026-05-08 10:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 20:38 [nft PATCH] scanner: Accept all statements' first words in all scopes Phil Sutter
2026-05-07 22:04 ` Florian Westphal
2026-05-08 10:21 ` Phil Sutter
2026-05-08 10:28 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af265E0SP78KxmpQ@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.