From: Breno Leitao <leitao@debian.org>
To: Tao Cui <cuitao@kylinos.cn>
Cc: andrew@lunn.ch, kuba@kernel.org, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, horms@kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: ethtool: fix missing closing paren in rings_reply_size()
Date: Fri, 8 May 2026 02:33:28 -0700 [thread overview]
Message-ID: <af2tj9AkacSUfsp9@gmail.com> (raw)
In-Reply-To: <20260508071402.183909-1-cuitao@kylinos.cn>
On Fri, May 08, 2026 at 03:14:02PM +0800, Tao Cui wrote:
> sizeof(u32) on the _RINGS_CQE_SIZE line is missing its closing
> parenthesis, causing nla_total_size() to absorb the subsequent
> _TX_PUSH and _RX_PUSH entries. The resulting size estimate
> happens to be numerically identical due to NLA alignment, but
> the nesting is wrong and misleading.
>
> Signed-off-by: Tao Cui <cuitao@kylinos.cn>
Reviewed-by: Breno Leitao <leitao@debian.org>
Even thought the resulting size is identical, I am wondering if you
should add the Fixes: here. (or target net-next instead).
I think this is a net material, which will require a Fixes: tag.
next prev parent reply other threads:[~2026-05-08 9:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 7:14 [PATCH] net: ethtool: fix missing closing paren in rings_reply_size() Tao Cui
2026-05-08 9:30 ` Vadim Fedorenko
2026-05-08 9:33 ` Breno Leitao [this message]
2026-05-08 10:04 ` [PATCH net v2] " Tao Cui
2026-05-08 12:07 ` Andrew Lunn
2026-05-08 20:41 ` [PATCH] " Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af2tj9AkacSUfsp9@gmail.com \
--to=leitao@debian.org \
--cc=andrew@lunn.ch \
--cc=cuitao@kylinos.cn \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.