All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, jani.nikula@linux.intel.com
Subject: Re: [PATCH 5/9] drm/dp: Refactor AS SDP logging to use space-separated field names
Date: Fri, 8 May 2026 17:36:13 +0300	[thread overview]
Message-ID: <af303Td06fAH4kuy@intel.com> (raw)
In-Reply-To: <20260428074457.3566918-6-ankit.k.nautiyal@intel.com>

On Tue, Apr 28, 2026 at 01:14:53PM +0530, Ankit Nautiyal wrote:
> Replace underscores with spaces in AS SDP log field labels to be
> consistent with the VSC SDP logging style.
> 
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/display/drm_dp_helper.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c
> index a697cc227e28..745559826cd9 100644
> --- a/drivers/gpu/drm/display/drm_dp_helper.c
> +++ b/drivers/gpu/drm/display/drm_dp_helper.c
> @@ -3508,10 +3508,10 @@ void drm_dp_as_sdp_log(struct drm_printer *p, const struct drm_dp_as_sdp *as_sdp
>  	drm_printf(p, "DP SDP: AS_SDP, revision %u, length %u\n",
>  		   as_sdp->revision, as_sdp->length);
>  	drm_printf(p, "    vtotal: %d\n", as_sdp->vtotal);
> -	drm_printf(p, "    target_rr: %d\n", as_sdp->target_rr);
> -	drm_printf(p, "    duration_incr_ms: %d\n", as_sdp->duration_incr_ms);
> -	drm_printf(p, "    duration_decr_ms: %d\n", as_sdp->duration_decr_ms);
> -	drm_printf(p, "    operation_mode: %d\n", as_sdp->mode);
> +	drm_printf(p, "    target rr: %d\n", as_sdp->target_rr);
> +	drm_printf(p, "    duration increase ms: %d\n", as_sdp->duration_incr_ms);
> +	drm_printf(p, "    duration decrease ms: %d\n", as_sdp->duration_decr_ms);
> +	drm_printf(p, "    operation mode: %d\n", as_sdp->mode);
>  }
>  EXPORT_SYMBOL(drm_dp_as_sdp_log);
>  
> -- 
> 2.45.2

-- 
Ville Syrjälä
Intel

  reply	other threads:[~2026-05-08 14:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-28  7:44 [PATCH 0/9] AS SDP cleanups and additions for Panel Replay + VRR Ankit Nautiyal
2026-04-28  7:44 ` [PATCH 1/9] drm/dp: Rename and relocate AS SDP payload field masks Ankit Nautiyal
2026-04-28  7:44 ` [PATCH 2/9] drm/dp: Clean up DPRX feature enumeration macros Ankit Nautiyal
2026-04-28  7:44 ` [PATCH 3/9] drm/dp: Add bits for AS SDP FAVT Payload Fields Parsing support Ankit Nautiyal
2026-04-28  7:44 ` [PATCH 4/9] drm/dp: Add DPCD for configuring AS SDP for PR + VRR Ankit Nautiyal
2026-04-28  7:44 ` [PATCH 5/9] drm/dp: Refactor AS SDP logging to use space-separated field names Ankit Nautiyal
2026-05-08 14:36   ` Ville Syrjälä [this message]
2026-04-28  7:44 ` [PATCH 6/9] drm/dp: Store coasting vtotal in struct drm_dp_as_sdp Ankit Nautiyal
2026-04-28  7:44 ` [PATCH 7/9] drm/dp: Add a helper to get the SDP type as a string Ankit Nautiyal
2026-05-08 14:38   ` Ville Syrjälä
2026-04-28  7:44 ` [PATCH 8/9] drm/dp: Add target_rr_divider field in AS SDP logging Ankit Nautiyal
2026-04-28  7:44 ` [PATCH 9/9] drm/dp: Use drm_printf_indent for DP " Ankit Nautiyal
2026-04-28 10:17   ` Jani Nikula
2026-04-28  8:31 ` ✓ CI.KUnit: success for AS SDP cleanups and additions for Panel Replay + VRR (rev2) Patchwork
2026-04-28  9:13 ` ✓ i915.CI.BAT: " Patchwork
2026-04-28  9:28 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-28 15:52 ` ✓ i915.CI.Full: " Patchwork
2026-04-28 17:34 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-05-11 14:21 ` [PATCH 0/9] AS SDP cleanups and additions for Panel Replay + VRR Nautiyal, Ankit K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af303Td06fAH4kuy@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.