All of lore.kernel.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Wade Farnsworth <wfarnsworth@mvista.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>, paulus@samba.org
Subject: Re: [PATCH] Fix the LPC47M192 SuperIO on the MPC8641 HPCN
Date: Thu, 7 Jun 2007 15:01:20 +0200	[thread overview]
Message-ID: <af3aa7bd5ff385f5ad94aa7c1d456a35@kernel.crashing.org> (raw)
In-Reply-To: <1181147415.5674.108.camel@rhino>

> +	/* enable superio @ 0x4e and keyboard/mouse address decoding */
> +	pci_write_config_byte(dev, 0x63, 0x90);

I doubt that comment is accurate.

> +	outb(0x07, 0x4e);	/* device selector register */
> +	outb(0x07, 0x4f);	/* select keyboard registers (device 7) */

Please abstract out the 4e,4f access sequence, so
you can just say  write_sio(0x30, 1);  or similar.

> +	/* Enable superio runtime registers for gpio in pci i/o space */
> +	outb(0x20, 0x4e);	/* device id register */

This write is superfluous as far as I can see.


Segher

  parent reply	other threads:[~2007-06-07 13:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-06 16:30 [PATCH] Fix the LPC47M192 SuperIO on the MPC8641 HPCN Wade Farnsworth
2007-06-06 22:39 ` Arnd Bergmann
2007-06-07 13:03   ` Segher Boessenkool
2007-06-07 16:04   ` Wade Farnsworth
2007-06-07 16:35     ` Segher Boessenkool
2007-06-07 16:51       ` Wade Farnsworth
2007-06-07 17:05         ` Segher Boessenkool
2007-06-07 20:01       ` Andy Fleming
2007-06-08  8:22         ` Segher Boessenkool
2007-06-07 13:01 ` Segher Boessenkool [this message]
2007-06-07 16:42   ` Wade Farnsworth
2007-06-07 17:04     ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af3aa7bd5ff385f5ad94aa7c1d456a35@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=wfarnsworth@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.