From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>, alsa-devel@alsa-project.org
Cc: vkoul@kernel.org, broonie@kernel.org, tiwai@suse.com,
lgirdwood@gmail.com
Subject: Re: [alsa-devel] [PATCH v4 00/11] ASoC: SOF: Data probing
Date: Fri, 31 Jan 2020 11:02:49 -0600 [thread overview]
Message-ID: <af43385c-9aa7-4faa-e889-0c2f01b65b5a@linux.intel.com> (raw)
In-Reply-To: <20200131123115.14247-1-cezary.rojewski@intel.com>
> Changes in v4:
> - No changes to ALSA core and hda patches
>
> - 'probe' source added in patch "ASoC: SOF: Implement Probe IPC API" now
> only compiled if SND_SOC_SOF_DEBUG_PROBES is enabled. Said kconfig
> initial declaration has been moved to that patch too
> - 'extractor_stream_tag' field now decorated with _DEBUG_PROBES to
> account for the change above
> - Debugfs probe handlers now check if extractor stream is running before
> continuing. To achieve this, 'extractor_stream_tag' is both initialized
> and set to SOF_PROBE_INVALID_NODE_ID on sof_probe_compr_free().
> Suggestion provided by Pierre
>
> - Reverted SND_SOC_SOF_HDA_LINK requirement-removal change for HDA probes.
> Code requires SND_HDA_EXT_CORE in order to function on Intel platforms
Sorry Cezary, I am not ok with this revert and the dependency on
HDA_LINK, see comment on Patch 9. We can talk on Monday on this to look
at alternate solutions, no need for multiple emails.
Also the types used in Patch 6 need a bit more work.
The rest looks fine, thanks!
-Pierre
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2020-01-31 17:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 12:31 [alsa-devel] [PATCH v4 00/11] ASoC: SOF: Data probing Cezary Rojewski
2020-01-31 12:31 ` [alsa-devel] [PATCH v4 01/11] ALSA: hda: Allow for compress stream to hdac_ext_stream assignment Cezary Rojewski
2020-01-31 12:31 ` [alsa-devel] [PATCH v4 02/11] ALSA: hda: Prepare for compress stream support Cezary Rojewski
2020-01-31 12:31 ` [alsa-devel] [PATCH v4 03/11] ALSA: hda: Interrupt servicing and BDL setup for compress streams Cezary Rojewski
2020-01-31 12:31 ` [alsa-devel] [PATCH v4 04/11] ALSA: core: Expand DMA buffer information Cezary Rojewski
2020-01-31 12:31 ` [alsa-devel] [PATCH v4 05/11] ALSA: core: Implement compress page allocation and free routines Cezary Rojewski
2020-01-31 12:31 ` [alsa-devel] [PATCH v4 06/11] ASoC: SOF: Intel: Account for compress streams when servicing IRQs Cezary Rojewski
2020-01-31 16:39 ` Pierre-Louis Bossart
2020-02-18 14:49 ` Cezary Rojewski
2020-01-31 12:31 ` [alsa-devel] [PATCH v4 07/11] ASoC: SOF: Implement Probe IPC API Cezary Rojewski
2020-01-31 12:31 ` [alsa-devel] [PATCH v4 08/11] ASoC: SOF: Generic probe compress operations Cezary Rojewski
2020-01-31 12:31 ` [alsa-devel] [PATCH v4 09/11] ASoC: SOF: Intel: Probe " Cezary Rojewski
2020-01-31 17:05 ` Pierre-Louis Bossart
2020-01-31 12:31 ` [alsa-devel] [PATCH v4 10/11] ASoC: SOF: Provide probe debugfs support Cezary Rojewski
2020-01-31 12:31 ` [alsa-devel] [PATCH v4 11/11] ASoC: SOF: Intel: Add Probe compress CPU DAIs Cezary Rojewski
2020-01-31 17:02 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af43385c-9aa7-4faa-e889-0c2f01b65b5a@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.