From: "Daniel P. Berrangé" <berrange@redhat.com>
To: marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v2 07/10] qom: add object_new_with_props_from_qdict
Date: Fri, 8 May 2026 16:51:56 +0100 [thread overview]
Message-ID: <af4GnFmd6Utll2DY@redhat.com> (raw)
In-Reply-To: <177825350909.389613.8952282324650958656.b4-review@b4>
On Fri, May 08, 2026 at 07:18:29PM +0400, marcandre.lureau@redhat.com wrote:
> On Fri, 08 May 2026 12:24:26 +0100, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > diff --git a/include/qom/object.h b/include/qom/object.h
> > index 1b2b2702fc9..cd59f1f1718 100644
> > --- a/include/qom/object.h
> > +++ b/include/qom/object.h
> > @@ -700,6 +700,25 @@ Object *object_new_with_propv(const char *typename,
> > [ ... skip 13 lines ... ]
> > + * properties in a QDict.
> > + */
> > +Object *object_new_with_props_from_qdict(const char *typename,
> > + Object *parent,
> > + const char *id,
> > + QDict *props,
>
> This should take a const QDict, same for the _parentless added later.
Ah yes, that would match the existing object_set_props_from_qdict
signature.
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
next prev parent reply other threads:[~2026-05-08 15:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 11:24 [PATCH v2 00/10] qom: misc cleanups / fixes Daniel P. Berrangé
2026-05-08 11:24 ` [PATCH v2 01/10] qom: add trace events for object/property lifecycle Daniel P. Berrangé
2026-05-08 15:18 ` marcandre.lureau
2026-05-08 15:47 ` Daniel P. Berrangé
2026-05-08 11:24 ` [PATCH v2 02/10] qom: validate ID format when creating objects Daniel P. Berrangé
2026-05-11 10:35 ` Philippe Mathieu-Daudé
2026-05-11 10:37 ` Philippe Mathieu-Daudé
2026-05-11 10:39 ` Daniel P. Berrangé
2026-05-08 11:24 ` [PATCH v2 03/10] qom: make errp last param in methods taking va_list Daniel P. Berrangé
2026-05-08 11:24 ` [PATCH v2 04/10] qom: shorten name of object_set_properties_from_keyval Daniel P. Berrangé
2026-05-08 11:24 ` [PATCH v2 05/10] qom: have object_set_props_keyval return bool Daniel P. Berrangé
2026-05-11 10:32 ` Philippe Mathieu-Daudé
2026-05-08 11:24 ` [PATCH v2 06/10] qom: move object_set_prop_keyval into object.c Daniel P. Berrangé
2026-05-11 10:37 ` Philippe Mathieu-Daudé
2026-05-08 11:24 ` [PATCH v2 07/10] qom: add object_new_with_props_from_qdict Daniel P. Berrangé
2026-05-08 15:18 ` marcandre.lureau
2026-05-08 15:51 ` Daniel P. Berrangé [this message]
2026-05-08 11:24 ` [PATCH v2 08/10] qom: fix ability to create objects without a parent Daniel P. Berrangé
2026-05-08 11:24 ` [PATCH v2 09/10] qom: allow object_new_with_prop* to trigger module loading Daniel P. Berrangé
2026-05-08 11:24 ` [PATCH v2 10/10] qom: drop user_creatable_add_type method Daniel P. Berrangé
2026-05-08 15:18 ` marcandre.lureau
2026-05-08 15:44 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af4GnFmd6Utll2DY@redhat.com \
--to=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.