From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41775CD3445 for ; Fri, 8 May 2026 16:10:41 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wLNmP-00009S-3z; Fri, 08 May 2026 12:10:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wLNmL-000096-RS for qemu-devel@nongnu.org; Fri, 08 May 2026 12:10:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wLNmJ-0005a8-4D for qemu-devel@nongnu.org; Fri, 08 May 2026 12:10:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778256614; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=I+YCsQjIgri8l4qsFPRgyn54LOHBz/wJqOqdyHAuUDQ=; b=Xiin/EKutLIJhJiUKe3XId5AAc2wZEOcFoK5CWa7YQISaI+Pqy0M5unVMNigWstqUCoRZh U6P44ubfzXtvDdm2dfdbcFqWtYzok9k2mORoWwcbgUxVIWyyAQxjePc1R1mNLvWEuM5S7H 3RTgr2HC0SrCK+V+ylMRgMSuW0hmot8= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-2-8R_ULiHJNHOMp-NbtaEDiw-1; Fri, 08 May 2026 12:10:10 -0400 X-MC-Unique: 8R_ULiHJNHOMp-NbtaEDiw-1 X-Mimecast-MFC-AGG-ID: 8R_ULiHJNHOMp-NbtaEDiw_1778256609 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0563318005B2; Fri, 8 May 2026 16:10:09 +0000 (UTC) Received: from redhat.com (unknown [10.44.32.204]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E42033002D2F; Fri, 8 May 2026 16:10:04 +0000 (UTC) Date: Fri, 8 May 2026 17:10:01 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Pierrick Bouvier Cc: qemu-devel@nongnu.org, Anton Johansson , marcandre.lureau@redhat.com, Markus Armbruster , Paolo Bonzini , Richard Henderson , Max Filippov , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH v4 0/6] single-binary: deduplicate target_info() Message-ID: References: <20260505224826.2698753-1-pierrick.bouvier@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260505224826.2698753-1-pierrick.bouvier@oss.qualcomm.com> User-Agent: Mutt/2.3.1 (2026-03-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.44, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, May 05, 2026 at 03:48:20PM -0700, Pierrick Bouvier wrote: > We are getting close to be able to link several targets in a single QEMU system > binary, and the last obstacle on the road is to embed several TargetInfo in the > same binary. The end result of this series is to have a single definition for > target_info symbol. > > This series adds TargetInfo types in QOM, and retrieve them dynamically(). At > the moment, we don't deal yet with multiple TargetInfo selection, but install > all that is needed to be able to do it easily. > > Because TargetInfo data is set through class_init, it creates an issue at > startup, where we may try to instantiate additional (unrelated) types just to > retrieve the list of "target-info-X" types. Those other types class_init may be > using target information, to add target specific properties for instance. > This issue has been fixed by adding a new object_class_get_list_by_name_prefix > that does not force instantiation of all QOM types, but only those matching a > specific pattern. This way, we first initialize and retrieve target-info types > before others. > > An alternative would be to leave all this out of QOM, and use startup > initializer to add them in a single list. However, because all the single-binary > work has been using QOM where possible, it would be really sad to not use it for > this final step. Comments are welcome! > > Finally, sticking to our promise not create a special "single-binary > configuration", the goal is to use the *exact* same codepath for normal binaries > also. It means that even for existing system binaries, the goal will be to use > QOM to retrieve current target, even if there is only one. > > v4 > -- > > - Revert to v2 MODULE_INIT_TARGET_INFO as Daniel didn't comment on issues about > about MODULE_INIT_QOM_EARLY. Sorry for not responding to that, other things got in the way this week. For clarity, I withdraw my objections from v2. Having seen how my suggested approadch in v3 looked, I think you were correct all along. With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|