From: Jens Axboe <axboe@kernel.dk>
To: Alejandro Colomar <alx@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-man@vger.kernel.org,
"Darrick J . Wong" <djwong@kernel.org>
Subject: Re: RWF_DONTCACHE documentation
Date: Mon, 18 Aug 2025 14:42:54 -0600 [thread overview]
Message-ID: <af82ddad-82c1-4941-a5b5-25529deab129@kernel.dk> (raw)
In-Reply-To: <dargd4lgdazaqxrw7gz6drrzzgonn34qllkcgei4uxs6ft7jbz@avkuehcbaok6>
On 8/17/25 10:01 PM, Alejandro Colomar wrote:
> Hi Jens,
>
> On Mon, Aug 11, 2025 at 11:25:52AM -0600, Jens Axboe wrote:
>>> Other than this comments, the text looks good to me. Thanks!
>>
>> I kind of walked away from this one as I didn't have time or motivation
>> to push it forward. FWIW, if you want to massage it into submission
>> that'd be greatly appreciated. I'm not a regular man page contributor
>> nor do I aim to be, but I do feel like we should this feature
>> documented.
>
> I understand your lack of interest in writing quality man(7) source code
> if that means iterations of patches. However, you may find the build
It's not really lack of interest, it's just that there's only so much
time and the idea of a back and forth on documentation isn't high on the
list :-)
> system helpful to find some of the most obvious mistakes by yourself.
> This might help you in future patches.
>
> $ make lint-man build-all -R
> TROFF .tmp/man/man2/readv.2.cat.set
> an.tmac:.tmp/man/man2/readv.2:316: style: .IR expects at least 2 arguments, got 1
> an.tmac:.tmp/man/man2/readv.2:395: style: .IR expects at least 2 arguments, got 1
> make: *** [/srv/alx/src/linux/man-pages/man-pages/contrib/share/mk/build/catman/troff.mk:66: .tmp/man/man2/readv.2.cat.set] Error 1
> make: *** Deleting file '.tmp/man/man2/readv.2.cat.set'
I'll remember for next time!
> Here's a diff with all the issues I raised fixed. Please add a commit
> message, and I'll apply it.
Beautiful, thank you! Maybe paste the same section into writev.2 as
well? For commit message, something ala
man/man2/readv.2: document RWF_DONTCACHE
Add a description of the RWF_DONTCACHE IO flag, which tells the kernel
that any page cache instantiated by this IO, should be dropped when the
operation has completed.
?
--
Jens Axboe
next prev parent reply other threads:[~2025-08-18 20:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-02 15:00 RWF_DONTCACHE documentation Christoph Hellwig
2025-06-02 15:49 ` Jens Axboe
2025-06-02 20:54 ` Jens Axboe
2025-06-11 8:41 ` Alejandro Colomar
2025-08-11 17:25 ` Jens Axboe
2025-08-18 4:01 ` Alejandro Colomar
2025-08-18 20:42 ` Jens Axboe [this message]
2025-09-01 14:22 ` [PATCH v2] man/man2/readv.2: Document RWF_DONTCACHE Alejandro Colomar
2025-09-01 14:34 ` Alejandro Colomar
2025-09-01 14:36 ` Jens Axboe
2025-11-24 17:16 ` Alejandro Colomar
2025-09-02 5:21 ` Christoph Hellwig
2025-11-24 17:15 ` Alejandro Colomar
2025-06-03 6:20 ` RWF_DONTCACHE documentation Johannes Thumshirn
2025-06-03 13:10 ` Jens Axboe
2025-06-03 18:19 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af82ddad-82c1-4941-a5b5-25529deab129@kernel.dk \
--to=axboe@kernel.dk \
--cc=alx@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.