Re: [PATCH 0/7] drm/i915: move towards kernel types

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 12/06/2018 10:19, Jani Nikula wrote:
> Semi-RFC. Do we want to do this? Here's a batch of conversions that shouldn't
> conflict much with in-flight patches.
> 
> The trouble with mixed use is that it's inconsistent, and any remaining C99
> types will encourage their use. We could at least do the low hanging fruit?

Ack from me. Doesn't seem so big to cause much pain.

When you say low-hanging fruit, that implies you only dealt with a 
particular class of occurrences?

Also going forward we have to make sure we will be able to stop them 
creeping back in. Is checkpatch perhaps covering this? Or we could put 
something in dim?

Regards,

Tvrtko

> $ git grep "uint\(8\|16\|32\|64\)_t" -- drivers/gpu/drm/i915/ | sed 's/:.*//' | sort | uniq -c | sort -n
> 
> BR,
> Jani.
> 
> 
> Jani Nikula (7):
>    drm/i915/vbt: switch to kernel unsigned int types
>    drm/i915/hdmi: switch to kernel unsigned int types
>    drm/i915/uncore: switch to kernel unsigned int types
>    drm/i915/dvo: switch to kernel unsigned int types
>    drm/i915/backlight: switch to kernel unsigned int types
>    drm/i915/audio: switch to kernel unsigned int types
>    drm/i915/lspcon: switch to kernel unsigned int types
> 
>   drivers/gpu/drm/i915/dvo_ch7017.c             | 20 ++++++------
>   drivers/gpu/drm/i915/dvo_ch7xxx.c             | 22 +++++++-------
>   drivers/gpu/drm/i915/dvo_ivch.c               | 26 ++++++++--------
>   drivers/gpu/drm/i915/dvo_ns2501.c             | 44 +++++++++++++--------------
>   drivers/gpu/drm/i915/dvo_sil164.c             | 10 +++---
>   drivers/gpu/drm/i915/dvo_tfp410.c             | 16 +++++-----
>   drivers/gpu/drm/i915/intel_audio.c            | 36 +++++++++++-----------
>   drivers/gpu/drm/i915/intel_bios.c             |  4 +--
>   drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 12 ++++----
>   drivers/gpu/drm/i915/intel_dvo.c              |  2 +-
>   drivers/gpu/drm/i915/intel_hdmi.c             | 14 ++++-----
>   drivers/gpu/drm/i915/intel_lspcon.c           |  2 +-
>   drivers/gpu/drm/i915/intel_panel.c            |  8 ++---
>   drivers/gpu/drm/i915/intel_uncore.h           | 22 +++++++-------
>   drivers/gpu/drm/i915/intel_vbt_defs.h         |  2 +-
>   15 files changed, 120 insertions(+), 120 deletions(-)
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx