From: Andrea Righi <arighi@nvidia.com>
To: K Prateek Nayak <kprateek.nayak@amd.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
Christian Loehle <christian.loehle@arm.com>,
Koba Ko <kobak@nvidia.com>,
Felix Abecassis <fabecassis@nvidia.com>,
Balbir Singh <balbirs@nvidia.com>,
Joel Fernandes <joelagnelf@nvidia.com>,
Shrikanth Hegde <sshegde@linux.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] sched/topology: Remove SMT/asym capacity warning
Date: Tue, 28 Apr 2026 07:54:00 +0200 [thread overview]
Message-ID: <afBLeFl-Iwta3WjO@gpd4> (raw)
In-Reply-To: <10a7ac82-5e08-4a01-b318-8f3e1d392c57@amd.com>
On Tue, Apr 28, 2026 at 10:58:05AM +0530, K Prateek Nayak wrote:
> Hello Andrea,
>
> On 4/28/2026 10:46 AM, Andrea Righi wrote:
> > @@ -1732,10 +1732,6 @@ sd_init(struct sched_domain_topology_level *tl,
> > .name = tl->name,
> > };
> >
> > - WARN_ONCE((sd->flags & (SD_SHARE_CPUCAPACITY | SD_ASYM_CPUCAPACITY)) ==
> > - (SD_SHARE_CPUCAPACITY | SD_ASYM_CPUCAPACITY),
> > - "CPU capacity asymmetry not supported on SMT\n");
> > -
>
> Wait! Doesn't this mean we have ASYM_CAPACITY between the SMT siblings?
> That seems wrong since we expect the siblings of cores to have the same
> capacity.
>
> Have you tripped this warning during your testing?
Hm... I think you're right, I may have seen this only in a VM, let me double
check.
-Andrea
next prev parent reply other threads:[~2026-04-28 5:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 5:16 [PATCH v4 0/6] sched/fair: SMT-aware asymmetric CPU capacity Andrea Righi
2026-04-28 5:16 ` [PATCH 1/6] sched/fair: Use guard(rcu) for sched_domain RCU sections Andrea Righi
2026-04-28 8:33 ` K Prateek Nayak
2026-04-28 10:43 ` Andrea Righi
2026-04-28 11:04 ` K Prateek Nayak
2026-04-28 11:50 ` Peter Zijlstra
2026-04-28 13:16 ` Andrea Righi
2026-04-28 14:12 ` Steven Rostedt
2026-04-28 14:26 ` Andrea Righi
2026-04-28 14:29 ` Steven Rostedt
2026-04-28 5:16 ` [PATCH 2/6] sched/fair: Attach sched_domain_shared to sd_asym_cpucapacity Andrea Righi
2026-04-28 6:45 ` Shrikanth Hegde
2026-04-28 8:47 ` Andrea Righi
2026-04-28 5:16 ` [PATCH 3/6] sched/fair: Prefer fully-idle SMT cores in asym-capacity idle selection Andrea Righi
2026-04-28 5:16 ` [PATCH 4/6] sched/fair: Reject misfit pulls onto busy SMT siblings on asym-capacity Andrea Righi
2026-04-28 5:16 ` [PATCH 5/6] sched/fair: Add SIS_UTIL support to select_idle_capacity() Andrea Righi
2026-04-28 5:16 ` [PATCH 6/6] sched/topology: Remove SMT/asym capacity warning Andrea Righi
2026-04-28 5:28 ` K Prateek Nayak
2026-04-28 5:54 ` Andrea Righi [this message]
2026-04-28 6:04 ` Andrea Righi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afBLeFl-Iwta3WjO@gpd4 \
--to=arighi@nvidia.com \
--cc=balbirs@nvidia.com \
--cc=bsegall@google.com \
--cc=christian.loehle@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=fabecassis@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=juri.lelli@redhat.com \
--cc=kobak@nvidia.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sshegde@linux.ibm.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.