From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jiawei liu <liujiawei4419@gmail.com>
Cc: linux-serial@vger.kernel.org, gregkh@linuxfoundation.org,
jirislaby@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_pci: skip WCH PCI serial devices
Date: Tue, 28 Apr 2026 11:56:53 +0200 [thread overview]
Message-ID: <afCEZY31cb-eJXrJ@black.igk.intel.com> (raw)
In-Reply-To: <CAGDm1S3mCv_7usfP0dx9jqj+mt_vBD4z8gu5wVyPbXB2Kh-mgg@mail.gmail.com>
On Tue, Apr 28, 2026 at 04:26:34PM +0800, Jiawei liu wrote:
> WCH PCI serial devices implement vendor-specific extensions
> beyond the standard 16C550 UART. These are not supported by
> the generic 8250 PCI driver, and binding them may lead to
> incorrect or suboptimal operation.
>
> Skip these devices during probe to avoid misbinding.
>
> Signed-off-by: Jiawei Liu <liujiawei4419@gmail.com>
Besides the broken way on sending patches — spend your time reading
documentation and reviewing others' code first, please, — this change
breaks the cases where it works.
100% NAK. Try again when you will have a driver that supports them including
mentioned vendor extensions, before that this patch won't ever be accepted.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-04-28 9:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 8:26 [PATCH] serial: 8250_pci: skip WCH PCI serial devices Jiawei liu
2026-04-28 9:56 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afCEZY31cb-eJXrJ@black.igk.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=liujiawei4419@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.