All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: ticotimo@gmail.com
Cc: meta-virtualization@lists.yoctoproject.org,
	Tim Orling <tim.orling@konsulko.com>
Subject: Re: [meta-virtualization][PATCH] test_vdkr_registry: fix test_image_requires_subcommand
Date: Tue, 28 Apr 2026 11:47:43 +0000	[thread overview]
Message-ID: <afCeX7WSBMP-aBOv@gmail.com> (raw)
In-Reply-To: <20260428003340.78253-2-tim.orling@konsulko.com>

merged.

Bruce

In message: [meta-virtualization][PATCH] test_vdkr_registry: fix test_image_requires_subcommand
on 27/04/2026 Tim Orling via lists.yoctoproject.org wrote:

> vdkr.run() merges stderr into stdout (see conftest.py), so the
> error message ends up in result.stdout even though the script
> writes it to stderr (>&2).
> 
> Signed-off-by: Tim Orling <tim.orling@konsulko.com>
> ---
>  tests/test_vdkr_registry.py | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/test_vdkr_registry.py b/tests/test_vdkr_registry.py
> index 9073444d..72a27169 100644
> --- a/tests/test_vdkr_registry.py
> +++ b/tests/test_vdkr_registry.py
> @@ -259,7 +259,11 @@ class TestImageCompoundCommands:
>          """Test that 'image' without subcommand shows error."""
>          result = self.vdkr.run("image", check=False)
>          assert result.returncode != 0
> -        assert "subcommand" in result.stderr.lower() or "requires" in result.stderr.lower()
> +        # vdkr.run() merges stderr into stdout (see conftest.py), so the
> +        # error message ends up in result.stdout even though the script
> +        # writes it to stderr (>&2).
> +        combined = (result.stdout + result.stderr).lower()
> +        assert "subcommand" in combined or "requires" in combined
>  
>  
>  class TestRegistryCLIOverride:
> -- 
> 2.50.1 (Apple Git-155)
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#9748): https://lists.yoctoproject.org/g/meta-virtualization/message/9748
> Mute This Topic: https://lists.yoctoproject.org/mt/119041586/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 



      reply	other threads:[~2026-04-28 11:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-28  0:33 [meta-virtualization][PATCH] test_vdkr_registry: fix test_image_requires_subcommand Tim Orling
2026-04-28 11:47 ` Bruce Ashfield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afCeX7WSBMP-aBOv@gmail.com \
    --to=bruce.ashfield@gmail.com \
    --cc=meta-virtualization@lists.yoctoproject.org \
    --cc=ticotimo@gmail.com \
    --cc=tim.orling@konsulko.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.