Re: [PATCH v2 1/2] drm/xe/xe_ras: Add types and commands for RAS GPU health indicator

[Andi Shyti <andi.shyti@kernel.org>]

Hi Soham,

...

> diff --git a/drivers/gpu/drm/xe/xe_sysctrl_mailbox_types.h b/drivers/gpu/drm/xe/xe_sysctrl_mailbox_types.h
> index 89456aec6097..fc73e02c3202 100644
> --- a/drivers/gpu/drm/xe/xe_sysctrl_mailbox_types.h
> +++ b/drivers/gpu/drm/xe/xe_sysctrl_mailbox_types.h
> @@ -10,6 +10,21 @@
>  
>  #include "abi/xe_sysctrl_abi.h"
>  
> +/**
> + * enum xe_sysctrl_mailbox_command_id - RAS Command ID's for GFSP group

supernit: /ID's/IDs/

> + *
> + * @XE_SYSCTRL_CMD_GET_HEALTH: Get current health status
> + * @XE_SYSCTRL_CMD_SET_HEALTH: Set new health status
> + */
> +enum xe_sysctrl_mailbox_command_id {
> +	XE_SYSCTRL_CMD_GET_HEALTH = 0x0B,
> +	XE_SYSCTRL_CMD_SET_HEALTH = 0x0C
> +};
> +
> +enum xe_sysctrl_group {
> +	XE_SYSCTRL_GROUP_GFSP = 1
> +};

This is the only enum without comment. Is there any reason?

The rest of the patch looks good!

Thanks,
Andi

> +
>  /**
>   * struct xe_sysctrl_mailbox_command - System Controller mailbox command
>   */
> -- 
> 2.34.1
>