Re: hp-wmi: Fix thermal profile board classification for HP Omen Max 16 (8D41)

[Krishna Chomal <krishna.chomal108@gmail.com>]

Hi Ilpo,

Sorry for the delay in response, I forgot to update you but I was
working with Benjamin Young to get more information about this issue. It
turns out this is related to a failure in fan table parsing. Luckily this
was detected for a similar HP Omen Max device earlier and I had submitted
a fix for it [1]. It has been merged into the mainline kernel in 7.1-rc1,
so the issue should be automatically resolved for Benjamin whenever the
said kernel is released.

Meanwhile I have taken this opportunity to determine EC offsets for
board 8D41 in order to remove the "Unknown EC layout for board 8D41.
Thermal profile readback will be disabled. Please report this to
platform-driver-x86@vger.kernel.org" warning in their dmesg. I will send
a fix patch for this soon.

[1] https://lore.kernel.org/all/20260410191039.125659-2-krishna.chomal108@gmail.com/

On Fri, Apr 24, 2026 at 02:58:43PM +0300, Ilpo Järvinen wrote:
>Hi Krishna,
>
>Could please take a look what's going on here. It seems 8D41 was in
>victus_s_thermal_profile_boards[] even before the dmi_system_id
>conversion in the commit 8ca7515d3c76 ("platform/x86: hp-wmi: fix
>platform profile values for Omen 16-wf1xxx").
>
>On Wed, 22 Apr 2026, Ben Young wrote:
>
>> Unfortunately - the fans do not change speed upon terminal commands. The
>> HP-WMI is properly loaded and recognizes the board, but appears to not
>> allow any level of fan change. Do you have any recommendations? This is
>> important to HP laptop owners.
>>
>> Thank you!
>>
>> Sent from my iPhone
>>
>> > On Apr 21, 2026, at 8:18 PM, Benjamin Young <benj.n.yng@gmail.com> wrote:
>> >
>> > Subject: hp-wmi: Fix thermal profile board classification for HP Omen Max 16 (8D41)
>> >
>> > Board 8D41 (HP Omen MAX Gaming Laptop 16t-ah000) was incorrectly added
>> > to victus_s_thermal_profile_boards in kernel 7.0, causing hp-wmi probe
>> > to fail with -EINVAL.
>> >
>> > The fix is to remove 8D41 from victus_s_thermal_profile_boards and add
>> > it to omen_thermal_profile_boards whitelist instead.
>> >
>> > Tested on HP Omen MAX Gaming Laptop 16t-ah000, BIOS F.21, kernel
>> > 7.0.0-1-cachyos-bore. After the fix, hp_wmi registers successfully as
>> > a platform profile handler.
>> >
>>
>
>-- 
> i.