Re: [PATCH] hw/arm/raspi4b: NOP all DTB nodes when removing unimplemented devices

[Osama Abdelkader <osama.abdelkader@gmail.com>]

On Mon, Apr 27, 2026 at 01:07:00PM +0200, Philippe Mathieu-Daudé wrote:
> On 27/4/26 11:53, Peter Maydell wrote:
> > On Mon, 20 Apr 2026 at 17:21, Osama Abdelkader
> > <osama.abdelkader@gmail.com> wrote:
> > > 
> > > fdt_node_offset_by_compatible(fdt, -1, compat) only finds the first match.
> > > If the blob has more than one node with the same compatible string, extra
> > > nodes will remain active. using the same loop as imx8mp-evk.c
> > > 
> > > Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> > > ---
> > 
> > I wondered about whether it would be worth abstracting this
> > out into a helper function, but it looks like at the moment
> > only this raspi code and the imx8mp-evk do this. If we get
> > more places we want this we might do that, but not worth
> > it for two.
> 
> IIRC you were first against the approach of "use a real world
> dtb and patch it", recommending to "generate a dtb with what
> we emulate"; and we merged that as 'temporary kludge until we
> properly emulate the missing device'.

Thanks Peter and Philippe for the clarification, I would be happy to participate
in that solution too.

Best regards,
Osama