From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77B724A35; Tue, 28 Apr 2026 20:53:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.20 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777409588; cv=fail; b=eSX5bHM1uTC99c+BDzPHfRE/kCBHgNcUNjQOQtBGJUUIsfG/J+k+RmO/RpWUFmTAQVLbJU13sOfCMei7BFqG9H0FQ8z9xLWWQ5rwuxlaR5+PiQn6b+i+wjGrb7jsRza1dYUZquZ+y1q+8AvolWh0RtJjwaeJD10lyYHDhQ/VFEA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777409588; c=relaxed/simple; bh=IkuULx17/Gb7O3qahHYeBd79z+smxjG1qbq5JBzNJN0=; h=Date:From:To:CC:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=IvwkEI8kdcZZkT/d62GxHCIzZFcHXBp6bCNyEzxay1KJMMbmCLqfn7BYyNpwTdEQzVtk2ZVo6yocf76yZiD0Q+aK4D4/k6lKcWtFRPGn/Fm3C3MVHHSAfWjm0FlGBLwbk/flgqzhQBgkfO/53zEBGqme6SP7goi9jFwiu27o2OE= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=W98y8/u6; arc=fail smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="W98y8/u6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777409587; x=1808945587; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=IkuULx17/Gb7O3qahHYeBd79z+smxjG1qbq5JBzNJN0=; b=W98y8/u6sb10u7CqGsozi/J0p0bRsM/yeNPvaQAGnsQJCn0dE56/cW/v HLYTNvsfmajBd2wC8fl6UB9H2JsDKTVZwc1dZ7tP+XOHvoixzGCR1ra7F FRrxOoAtJEQamkXS7+TBR4sm6wzUR4TqANU1U77XHW3VOu24ZHZmbADm9 9eONFhc2SMAIhz6SI35YofkC3pJbDVbwo6IxGb6RG3kXYeRGpZWbwSoMd Pd20Ec5P+V7O1aoNwJRvKtZ7MZCye2plsR/lEyti/E/CYPmYdLIKqv7ME 2UqZVfBESAvGmTNhgiuC1wMEmUWezXhnlhpkAtWFYTKkr4RQX8I6pDd/6 g==; X-CSE-ConnectionGUID: 35EnOh+NQCOnCDXk1+B5xg== X-CSE-MsgGUID: EcjYIsopR0GuR/e0aqG/aw== X-IronPort-AV: E=McAfee;i="6800,10657,11770"; a="78039193" X-IronPort-AV: E=Sophos;i="6.23,204,1770624000"; d="scan'208";a="78039193" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2026 13:53:06 -0700 X-CSE-ConnectionGUID: VUkEwDPMTOWWOWMMpaKUtQ== X-CSE-MsgGUID: yy39WP1xRNKhCVcF68l0SQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,204,1770624000"; d="scan'208";a="239106097" Received: from fmsmsx902.amr.corp.intel.com ([10.18.126.91]) by orviesa005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2026 13:53:06 -0700 Received: from FMSMSX903.amr.corp.intel.com (10.18.126.92) by fmsmsx902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 28 Apr 2026 13:53:05 -0700 Received: from fmsedg902.ED.cps.intel.com (10.1.192.144) by FMSMSX903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Tue, 28 Apr 2026 13:53:05 -0700 Received: from CY3PR05CU001.outbound.protection.outlook.com (40.93.201.44) by edgegateway.intel.com (192.55.55.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 28 Apr 2026 13:53:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NWrRhezhQymHdiR9/9PCZfBNaOD7SP5mJkVHEG+j3L9OwnNgEjyylqZPusJ9c82KfeFnoPau01Lt5tVRbOLK1jhAPYjg2OThiMhF7o1GThLk7UxEqj/aVHm98qGTaMNDRkeTs/wfZbU62pc/yDyP1sYTsYqgw3wf1f57iOcCFOQDH9JMDlCJz+Xx0E8cUyYjIQ2C1X+G3VoG3F98V0XVTp4hEsMMk5EpHr5F1K40mV130LfhUuQcu/CTCNcZUhlF+u9BwSGGyJk2XJfD6ZaWxXvHqBjFVaRcwbvoDkQdoKZ38cy2ccEOu/vGN3IqBXGqkWk3tuppaN5d3Rhrgvem2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3HbVQq1Fld6tlebymoT8BqSHJmFVR2oB2vobsTVlDV0=; b=cuv363iVmJb4hzEd+ZIf1E3zTf9DqgG6LEAznI/Pu4DhB2O2iQjJcCtguhbym4jZvlSIkh4zPO71ePCi+NxY1wPIxPxnygAFjZp6vtnUQ1Nqt6OlLQQjE/DI2crfFjFIpRxKClQqr6MGQVu+W6L+mXN2OZV++kURkUSkWW0JaaQM2TNUCiOeaUcBdSua3c2DvMse4trWRsu+ThDryJ3J41rMlZojWXr/WW+aScjKv+nvYgEc5VbwIWMBtejS9IpA5P5xm+y4vCseS96Xrhif5SnGbPLF4FOzhmHffDARjRijZiEwwkKdBn9yDq11hwiHbheCn66LZ4WxHQIEid13Lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ1PR11MB6083.namprd11.prod.outlook.com (2603:10b6:a03:48a::9) by CH3PR11MB7722.namprd11.prod.outlook.com (2603:10b6:610:122::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.16; Tue, 28 Apr 2026 20:52:55 +0000 Received: from SJ1PR11MB6083.namprd11.prod.outlook.com ([fe80::3454:2577:75f2:60a6]) by SJ1PR11MB6083.namprd11.prod.outlook.com ([fe80::3454:2577:75f2:60a6%7]) with mapi id 15.20.9870.016; Tue, 28 Apr 2026 20:52:55 +0000 Date: Tue, 28 Apr 2026 13:52:53 -0700 From: "Luck, Tony" To: Babu Moger CC: , , Reinette Chatre , "Peter Zijlstra (Intel)" , Ingo Molnar , Zhang Rui , Chen Yu , Subject: Re: [tip: x86/urgent] x86/resctrl: Fix SNC detection Message-ID: References: <20260303110100.367976706@infradead.org> <177263917393.1647592.6057050710859194701.tip-bot2@tip-bot2> <37ac0376-43a3-4283-a3d5-4d57b3bec578@amd.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <37ac0376-43a3-4283-a3d5-4d57b3bec578@amd.com> X-ClientProxiedBy: SJ0PR05CA0116.namprd05.prod.outlook.com (2603:10b6:a03:334::31) To SJ1PR11MB6083.namprd11.prod.outlook.com (2603:10b6:a03:48a::9) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PR11MB6083:EE_|CH3PR11MB7722:EE_ X-MS-Office365-Filtering-Correlation-Id: 8f5b4c13-14a0-40c0-42b6-08dea5681f4d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: JU48+U8wbYvCW8Zd7oGyhx2++tJGw8VdxgnKINj6KjCwyHpB8wRxC0p/oTzWgT3P+9zf//Vx4pscDXdegToKRVR0zCvC/R9/sY7tzBIAy5+NuQfwqx325BMtvDjNDuQSjoZokkAl1A1NI6RoFmxcrnBmuBvuVDt2lQwtFNohWlDOYtapLSJ1XvS5CcoHs47N6Iy5gcH7YxOtmDOvPAmI1i1kXDyqaZ95inoQDjuF5xRJ0qvLQtYPQ+CtvJ99rGz+KVh5/L89PIIAb1+imPcHG3Z++zvvymccU1xJMf4ppWTzyc7CD2ozcdAlw20Xe8O1fAUb+U+qwmMmgquHzZws5/bU6dgnbSUxHMIdETtIH3oxiAfSBVQ5FG2zEpEXohKuQl/YHNtKsUlLZ2DY924R4URvdWhlOfCcrS4YEgnw3p7JKCBOu9BFHUm2DdL60gtZnQDsFMw97M/DQnxNA4uAZ1Z8NRAsu4xb5UiYDK423HqEpnRtVAN/zcrfJVvDUTwwFNCwm8Be0nVZdHOGnUuK8L4U2EhclFdOMovhSsiFbKxhFAJHzGx0v8IvZiTGMWergMOCYd12rvZSiKzl0FS+sPbw6nB9z0IY1IbhDvpRu8UMHVVBm3NpZUF4QT39/6vrHbzxdkMzTr16KXraGO0oHval7fJpim2UuLceLJ+ScpRqfViBNEtxeaMwl71xcDoKCqejehMGRu3HU4BDGP2a9EJ0Vxn6bohSvLfHI2QG3IU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ1PR11MB6083.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?btp/sr8nvFaHQyZT2By03muAagGiAdP+8CnvucC/roXmSgVfXGoNBN26t4rU?= =?us-ascii?Q?RhQ1x/VJ7BtTLCm0ux9lKrF5VBX9KYNVmQxPPO/4dPhAFqxPi2FeHeiq9KV/?= =?us-ascii?Q?TRGgG1RVYuk5cGNIUsRKg9ASiPvP4RBwCa8owQQCSLAhYCOJg6OyzlmrIjem?= =?us-ascii?Q?aMvLxa+LlSky7elHQTGKYHv7YxjSgdruCThaf7JF2Vxl1ZQ/97UUkU442HX5?= =?us-ascii?Q?vd8UqTNi3Q8cM3/ld7eZ09FcA7AMg+zY5W4v4m5wRdkZs8I71Ppe6CGocwWn?= =?us-ascii?Q?rw5dFpDhrVbOoMokYBymmlwglgJzRJAD7mWN0FxTApVTL0WHb+X75+PatGfs?= =?us-ascii?Q?DheFM3AWHF7n1xU7aIyEN5lK6a/lDUSscX+GHPs3wZOjDliyOGiJ5hPhVgsG?= =?us-ascii?Q?FSLeWKUuLm9/F/B9QbtG/lrHl0XkaDXoA0qEML+n7zRiljrwVCJjYbKIkHqt?= =?us-ascii?Q?/YmjQDsHNaoELcwt3uc2P3Pc4ySPIWAcgYeljfcvUqQo1lcY4ZaFpsQvFcIS?= =?us-ascii?Q?F48/FLLwBgFP9Ur/uiVgz3Tmi5uc7zQ1uSB2Kerv05uIJdLl12eWNd2TNDDq?= =?us-ascii?Q?7P5AG3wzCcqoEITAR0rug33OsQQYlvh/lTEL0KjrEbrQBtfUoXKx30zsip4+?= =?us-ascii?Q?DLvl59caStE1fVF6/bzGyyAJSVZfral7u21x0hA7L/ua83KjfocvnRC7tz8O?= =?us-ascii?Q?t1QYIVP6mdQF0UYPfQeKhjYhKndUPGWBgP+ybmEP8eQDRvKiJAYPv/B0VyHd?= =?us-ascii?Q?HiemRsgYTvvflQsVJItaMJ9gsR0NXuIzSNWA4Afql+4pjvZ5tgzFbYdNs2fZ?= =?us-ascii?Q?1SRVw3oJbaRWon/SeYU1ry63UOGS6f25aHCUFr0wUfDHWn+fkD0tScSFslBn?= =?us-ascii?Q?JVmiZ0YJjr8XXI/rIsDM9a/p9P03K8t10TCCpM5+iN2w/0yDUDVh9orEHd77?= =?us-ascii?Q?daXXlKdikfzjpZXzCadCdLjWCJkflGSC7cxYjob0fVwfYVcd69phvRncjKXp?= =?us-ascii?Q?kM3XYF6n07pIP80BsIPf+p4qddCoivoAb0QLn8/7myiTNC+rltJIhCg/L4Ig?= =?us-ascii?Q?PtJdbvumz98RvbYlrNtdDZwBUd5yjNF8/yYH1oeu9TzMpbQodN6k/2zriM2w?= =?us-ascii?Q?nUGzB3GGudYNxqVnRcfe+jF0sRCbbl1UKJan8D8BU5yt5lsPfpNA93P9gzqS?= =?us-ascii?Q?tEb9hdipXnc60C0n1u3/+auZzhWpMib7JXTZyC7oLTSru5nGGWcCc/4RiBHs?= =?us-ascii?Q?uTgwZXs0j6Ab4MX/Gd3qM9LAXyLK624YkSPfkAginZZQL4/vaBnvJm4GTtII?= =?us-ascii?Q?ecoAg993D2bHMKyV1L0DxWoQHcVM2HdsUCJ/dmN6wCC4/F8EN65EjwWqWj5C?= =?us-ascii?Q?yQAQBxAe9mDQDg04vPxCaq1msx3vXyuCS3oyA+UKBljwMuBdqINLETxw/MgH?= =?us-ascii?Q?IE3QEzTUbZ4zYJB2onwnxy9lL2nvODKjQXymeOi+o0kcsSVrYoIaYn1nVLNN?= =?us-ascii?Q?kbihyZQMW6mozJ8e7PnFOo3r/TwaH0gncg5fz3Lz1Vin07TdYr5MB2RmT0iK?= =?us-ascii?Q?oTod7HQv6cknBDJ/smtLAtw8QuUAVA3TYZvM5VQttCazqA9OP90SMYwWEmd/?= =?us-ascii?Q?qOzAkuc3wkh6fIws+BslEfjNYbvbQM5iO88uCpju9PY6kYY95kDOLiVdUhH8?= =?us-ascii?Q?epjdh9O6/d7Qok6BJ+se0+Z2ytQrbNocNwnD3XvQm0aKHflCM+OLJnIkLIby?= =?us-ascii?Q?fkq+FpM8YA=3D=3D?= X-Exchange-RoutingPolicyChecked: I3CY02tckwaP1laHjZvC89cZyT+sKjEmRpGmQDExY+LLoh/QjeL2ZHdRBgypnUB0H/+w3lAIu/MAGd1kjv9hxJ29WroDi700ZyKGYZKTc6f0n3iri8QBIfwKexYrDA8IT0JwuBcgRhed55NvIFLUZinqnIaCVU9I3GqGf8iBsEWQf9d7QpkWocUGZxQnevW87sAaEjWu2Y+2OrAuKV60WfEKr85qlCw4Bck+gxS6/vpEwtVw+X0ST53SqMdT4qS8Vt9CJEcqA6jMyxBLkjUwHOORep8LlpJRnRV/MqQ0hcHjAs1FdgESP2c8YSTI933znDxx3r8vczT7Xet0hBzaeg== X-MS-Exchange-CrossTenant-Network-Message-Id: 8f5b4c13-14a0-40c0-42b6-08dea5681f4d X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6083.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2026 20:52:55.5388 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TKMcIMOWe90a2VUjN6RBcGe2VhyxsGlgPkIS3WbfZxhcIWe6BqGPI1CaFeAHTPAYq4eNiVndtEDHnicDwf7j7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7722 X-OriginatorOrg: intel.com On Tue, Apr 28, 2026 at 03:41:51PM -0500, Babu Moger wrote: > Hi Tony, ... > Saw these messages on AMD system(7.1.0-rc1). > > sudo dmesg |grep CoD > [ 6.614667] resctrl: CoD enabled system? Resctrl not supported > > > Might confuse some users. Not a big deal. But we should fix it in next > version. Babu, Indeed yes. Thanks for letting me know. I think this should fix it. Can you test please? -Tony --- diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/resctrl/monitor.c index 497cc57ac135..3d72ff5d0c25 100644 --- a/arch/x86/kernel/cpu/resctrl/monitor.c +++ b/arch/x86/kernel/cpu/resctrl/monitor.c @@ -374,7 +374,12 @@ static const struct x86_cpu_id snc_cpu_ids[] __initconst = { static __init int snc_get_config(void) { - int ret = topology_num_nodes_per_package(); + int ret; + + if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) + return 1; + + ret = topology_num_nodes_per_package(); if (ret > 1 && !x86_match_cpu(snc_cpu_ids)) { pr_warn("CoD enabled system? Resctrl not supported\n"); >