From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C103FF8867 for ; Wed, 29 Apr 2026 10:20:41 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wI21I-0007i3-5X; Wed, 29 Apr 2026 06:19:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wI21F-0007hr-Uc for qemu-devel@nongnu.org; Wed, 29 Apr 2026 06:19:50 -0400 Received: from linux.microsoft.com ([13.77.154.182]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wI21E-0004ZN-EK for qemu-devel@nongnu.org; Wed, 29 Apr 2026 06:19:49 -0400 Received: from example.com (unknown [167.220.208.81]) by linux.microsoft.com (Postfix) with ESMTPSA id 18E0B20B716C; Wed, 29 Apr 2026 03:19:44 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 18E0B20B716C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1777457986; bh=IO+7MXl7aePOSBkWGtmNA9lbM7o9BOOvEpcE1ryBj0A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PgOy66jydOOXJG2CsY7B3nEfUfnoTOxjDGOps+gQqvORJkbzAUUWmUvUUs21zVHdk HlmL3R9MS3TEF5YXrvh4XL7n21HKurEBHKFQGwC452/P+Cb03ofdLZAwHPo0Yz83XK ZUAUDXoVRzVcw1WscmNBHpilmzOtpLk54Y/TPti8= Date: Wed, 29 Apr 2026 12:19:41 +0200 From: Magnus Kulke To: Doru =?iso-8859-1?Q?Bl=E2nzeanu?= Cc: qemu-devel@nongnu.org, Wei Liu , Paolo Bonzini , Zhao Liu Subject: Re: [PATCH 1/6] target/i386/mshv: remove duplicate function for reading vcpu registers Message-ID: References: <20260428135053.251200-1-dblanzeanu@linux.microsoft.com> <20260428135053.251200-2-dblanzeanu@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260428135053.251200-2-dblanzeanu@linux.microsoft.com> Received-SPF: pass client-ip=13.77.154.182; envelope-from=magnuskulke@linux.microsoft.com; helo=linux.microsoft.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Apr 28, 2026 at 04:50:48PM +0300, Doru Blânzeanu wrote: > Remove function `fetch_guest_state` because it is a duplicate function > of `mshv_load_regs` function. > > Signed-off-by: Doru Blânzeanu > --- > target/i386/mshv/mshv-cpu.c | 21 +-------------------- > 1 file changed, 1 insertion(+), 20 deletions(-) > > diff --git a/target/i386/mshv/mshv-cpu.c b/target/i386/mshv/mshv-cpu.c > index 4ed6e7548f..9defd05db6 100644 > --- a/target/i386/mshv/mshv-cpu.c > +++ b/target/i386/mshv/mshv-cpu.c > @@ -1291,25 +1291,6 @@ static int handle_pio_non_str(const CPUState *cpu, > return 0; > } > > -static int fetch_guest_state(CPUState *cpu) > -{ > - int ret; > - > - ret = mshv_get_standard_regs(cpu); > - if (ret < 0) { > - error_report("Failed to get standard registers"); > - return -1; > - } > - > - ret = mshv_get_special_regs(cpu); > - if (ret < 0) { > - error_report("Failed to get special registers"); > - return -1; > - } > - > - return 0; > -} > - > static int read_memory(const CPUState *cpu, uint64_t initial_gva, > uint64_t initial_gpa, uint64_t gva, uint8_t *data, > size_t len) > @@ -1429,7 +1410,7 @@ static int handle_pio_str(CPUState *cpu, hv_x64_io_port_intercept_message *info) > X86CPU *x86_cpu = X86_CPU(cpu); > CPUX86State *env = &x86_cpu->env; > > - ret = fetch_guest_state(cpu); > + ret = mshv_load_regs(cpu); > if (ret < 0) { > error_report("Failed to fetch guest state"); > return -1; > -- > 2.53.0 Reviewed-by: Magnus Kulke