From: Paul Kocialkowski <paulk@sys-base.io>
To: Andre Przywara <andre.przywara@arm.com>
Cc: u-boot@lists.denx.de, Tom Rini <trini@konsulko.com>,
Quentin Schulz <quentin.schulz@cherry.de>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v2 3/3] sunxi: configs: enable power LEDs on 64-bit boards
Date: Wed, 29 Apr 2026 15:08:30 +0200 [thread overview]
Message-ID: <afICzqv7jawLFjyB@shepard> (raw)
In-Reply-To: <20260429092828.3076719-4-andre.przywara@arm.com>
[-- Attachment #1: Type: text/plain, Size: 9666 bytes --]
Hi Andre,
On Wed 29 Apr 26, 11:28, Andre Przywara wrote:
> We recently gained a simple way to enable a power LED very early in the
> SPL boot, through simple Kconfig variables.
>
> Add those symbols to those boards' defconfigs where the DT indicates a
> default-on power LED. The number used is <port bank> * 32 + <pin no>,
> an active low setup means CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_HIGH must be
> undefined.
>
> This will light up the power LED very early in the (SPL) boot phase on
> those 64-bit boards.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Paul Kocialkowski <paulk@sys-base.io>
All the best,
Paul
> ---
> configs/anbernic_rg35xx_h700_defconfig | 2 ++
> configs/bananapi_m64_defconfig | 2 ++
> configs/beelink_gs1_defconfig | 2 ++
> configs/liontron-h-a133l_defconfig | 3 +++
> configs/nanopi_neo2_defconfig | 2 ++
> configs/nanopi_neo_plus2_defconfig | 2 ++
> configs/orangepi_3_defconfig | 2 ++
> configs/orangepi_lite2_defconfig | 2 ++
> configs/orangepi_pc2_defconfig | 2 ++
> configs/orangepi_prime_defconfig | 2 ++
> configs/orangepi_zero2_defconfig | 2 ++
> configs/orangepi_zero_plus2_defconfig | 2 ++
> configs/orangepi_zero_plus_defconfig | 2 ++
> configs/radxa-cubie-a5e_defconfig | 3 +++
> configs/tanix_tx1_defconfig | 2 ++
> 15 files changed, 32 insertions(+)
>
> diff --git a/configs/anbernic_rg35xx_h700_defconfig b/configs/anbernic_rg35xx_h700_defconfig
> index 2fa57cbecce..2abea94e979 100644
> --- a/configs/anbernic_rg35xx_h700_defconfig
> +++ b/configs/anbernic_rg35xx_h700_defconfig
> @@ -16,6 +16,8 @@ CONFIG_DRAM_SUNXI_PHY_ADDR_MAP_1=y
> CONFIG_MACH_SUN50I_H616=y
> CONFIG_SUNXI_DRAM_H616_LPDDR4=y
> CONFIG_R_I2C_ENABLE=y
> +CONFIG_SPL_SUNXI_LED_STATUS=y
> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=268
> CONFIG_SPL_I2C=y
> CONFIG_SPL_SYS_I2C_LEGACY=y
> CONFIG_SYS_I2C_MVTWSI=y
> diff --git a/configs/bananapi_m64_defconfig b/configs/bananapi_m64_defconfig
> index d957071cb13..3d1f5d27e5d 100644
> --- a/configs/bananapi_m64_defconfig
> +++ b/configs/bananapi_m64_defconfig
> @@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-bananapi-m64"
> CONFIG_SPL=y
> CONFIG_MACH_SUN50I=y
> CONFIG_MMC_SUNXI_SLOT_EXTRA=2
> +CONFIG_SPL_SUNXI_LED_STATUS=y
> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=120
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> CONFIG_SUPPORT_EMMC_BOOT=y
> CONFIG_SUN8I_EMAC=y
> diff --git a/configs/beelink_gs1_defconfig b/configs/beelink_gs1_defconfig
> index de46d205453..ebac032915f 100644
> --- a/configs/beelink_gs1_defconfig
> +++ b/configs/beelink_gs1_defconfig
> @@ -5,6 +5,8 @@ CONFIG_SPL=y
> CONFIG_MACH_SUN50I_H6=y
> CONFIG_SUNXI_DRAM_H6_LPDDR3=y
> CONFIG_MMC_SUNXI_SLOT_EXTRA=2
> +CONFIG_SPL_SUNXI_LED_STATUS=y
> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=356
> # CONFIG_PSCI_RESET is not set
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> CONFIG_LED=y
> diff --git a/configs/liontron-h-a133l_defconfig b/configs/liontron-h-a133l_defconfig
> index 831d5b56e3a..836e8d12ff0 100644
> --- a/configs/liontron-h-a133l_defconfig
> +++ b/configs/liontron-h-a133l_defconfig
> @@ -23,6 +23,9 @@ CONFIG_MACH_SUN50I_A133=y
> CONFIG_SUNXI_DRAM_A133_LPDDR4=y
> CONFIG_MMC_SUNXI_SLOT_EXTRA=2
> CONFIG_R_I2C_ENABLE=y
> +CONFIG_SPL_SUNXI_LED_STATUS=y
> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=240
> +# CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_HIGH is not set
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> CONFIG_SPL_I2C=y
> CONFIG_SPL_SYS_I2C_LEGACY=y
> diff --git a/configs/nanopi_neo2_defconfig b/configs/nanopi_neo2_defconfig
> index 6704a24a880..63fa6bac9ba 100644
> --- a/configs/nanopi_neo2_defconfig
> +++ b/configs/nanopi_neo2_defconfig
> @@ -6,6 +6,8 @@ CONFIG_SPL=y
> CONFIG_MACH_SUN50I_H5=y
> CONFIG_DRAM_ZQ=3881977
> # CONFIG_DRAM_ODT_EN is not set
> +CONFIG_SPL_SUNXI_LED_STATUS=y
> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> CONFIG_SUN8I_EMAC=y
> CONFIG_USB_EHCI_HCD=y
> diff --git a/configs/nanopi_neo_plus2_defconfig b/configs/nanopi_neo_plus2_defconfig
> index e80e32a63d4..9d1b783476d 100644
> --- a/configs/nanopi_neo_plus2_defconfig
> +++ b/configs/nanopi_neo_plus2_defconfig
> @@ -7,6 +7,8 @@ CONFIG_MACH_SUN50I_H5=y
> CONFIG_DRAM_ZQ=3881977
> # CONFIG_DRAM_ODT_EN is not set
> CONFIG_MMC_SUNXI_SLOT_EXTRA=2
> +CONFIG_SPL_SUNXI_LED_STATUS=y
> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> CONFIG_SUN8I_EMAC=y
> CONFIG_USB_EHCI_HCD=y
> diff --git a/configs/orangepi_3_defconfig b/configs/orangepi_3_defconfig
> index 125137bc321..409fa705a06 100644
> --- a/configs/orangepi_3_defconfig
> +++ b/configs/orangepi_3_defconfig
> @@ -6,6 +6,8 @@ CONFIG_MACH_SUN50I_H6=y
> CONFIG_SUNXI_DRAM_H6_LPDDR3=y
> CONFIG_MMC_SUNXI_SLOT_EXTRA=2
> CONFIG_BLUETOOTH_DT_DEVICE_FIXUP="brcm,bcm4345c5"
> +CONFIG_SPL_SUNXI_LED_STATUS=y
> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=356
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> CONFIG_PHY_SUN50I_USB3=y
> CONFIG_USB_XHCI_HCD=y
> diff --git a/configs/orangepi_lite2_defconfig b/configs/orangepi_lite2_defconfig
> index 577f7436c15..5d72d34eb9d 100644
> --- a/configs/orangepi_lite2_defconfig
> +++ b/configs/orangepi_lite2_defconfig
> @@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h6-orangepi-lite2"
> CONFIG_SPL=y
> CONFIG_MACH_SUN50I_H6=y
> CONFIG_SUNXI_DRAM_H6_LPDDR3=y
> +CONFIG_SPL_SUNXI_LED_STATUS=y
> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=356
> # CONFIG_PSCI_RESET is not set
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> CONFIG_USB_EHCI_HCD=y
> diff --git a/configs/orangepi_pc2_defconfig b/configs/orangepi_pc2_defconfig
> index d856a25814b..464b34f4ec0 100644
> --- a/configs/orangepi_pc2_defconfig
> +++ b/configs/orangepi_pc2_defconfig
> @@ -6,6 +6,8 @@ CONFIG_SPL=y
> CONFIG_MACH_SUN50I_H5=y
> CONFIG_DRAM_ZQ=3881977
> CONFIG_SPL_SPI_SUNXI=y
> +CONFIG_SPL_SUNXI_LED_STATUS=y
> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> CONFIG_SPL_I2C=y
> CONFIG_SPL_SYS_I2C_LEGACY=y
> diff --git a/configs/orangepi_prime_defconfig b/configs/orangepi_prime_defconfig
> index e93154cc0e9..e5e9009378c 100644
> --- a/configs/orangepi_prime_defconfig
> +++ b/configs/orangepi_prime_defconfig
> @@ -6,6 +6,8 @@ CONFIG_SPL=y
> CONFIG_MACH_SUN50I_H5=y
> CONFIG_DRAM_ZQ=3881977
> # CONFIG_DRAM_ODT_EN is not set
> +CONFIG_SPL_SUNXI_LED_STATUS=y
> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> CONFIG_SUN8I_EMAC=y
> CONFIG_USB_EHCI_HCD=y
> diff --git a/configs/orangepi_zero2_defconfig b/configs/orangepi_zero2_defconfig
> index 831bfe66e25..b387b4795ad 100644
> --- a/configs/orangepi_zero2_defconfig
> +++ b/configs/orangepi_zero2_defconfig
> @@ -10,6 +10,8 @@ CONFIG_MACH_SUN50I_H616=y
> CONFIG_SUNXI_DRAM_H616_DDR3_1333=y
> CONFIG_R_I2C_ENABLE=y
> CONFIG_SPL_SPI_SUNXI=y
> +CONFIG_SPL_SUNXI_LED_STATUS=y
> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=76
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> CONFIG_SPL_I2C=y
> CONFIG_SPL_SYS_I2C_LEGACY=y
> diff --git a/configs/orangepi_zero_plus2_defconfig b/configs/orangepi_zero_plus2_defconfig
> index c4d9800975c..9758ffd385e 100644
> --- a/configs/orangepi_zero_plus2_defconfig
> +++ b/configs/orangepi_zero_plus2_defconfig
> @@ -7,6 +7,8 @@ CONFIG_MACH_SUN50I_H5=y
> CONFIG_DRAM_ZQ=3881977
> # CONFIG_DRAM_ODT_EN is not set
> CONFIG_MMC_SUNXI_SLOT_EXTRA=2
> +CONFIG_SPL_SUNXI_LED_STATUS=y
> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> CONFIG_SUN8I_EMAC=y
> CONFIG_USB_EHCI_HCD=y
> diff --git a/configs/orangepi_zero_plus_defconfig b/configs/orangepi_zero_plus_defconfig
> index 4b6491dc846..bb159428a14 100644
> --- a/configs/orangepi_zero_plus_defconfig
> +++ b/configs/orangepi_zero_plus_defconfig
> @@ -6,6 +6,8 @@ CONFIG_SPL=y
> CONFIG_MACH_SUN50I_H5=y
> CONFIG_DRAM_ZQ=3881977
> # CONFIG_DRAM_ODT_EN is not set
> +CONFIG_SPL_SUNXI_LED_STATUS=y
> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> CONFIG_SUN8I_EMAC=y
> CONFIG_USB_EHCI_HCD=y
> diff --git a/configs/radxa-cubie-a5e_defconfig b/configs/radxa-cubie-a5e_defconfig
> index 9d204ef5548..84bc4e3d4a9 100644
> --- a/configs/radxa-cubie-a5e_defconfig
> +++ b/configs/radxa-cubie-a5e_defconfig
> @@ -15,6 +15,9 @@ CONFIG_DRAM_SUNXI_TPR12=0x3533302f
> CONFIG_MACH_SUN55I_A523=y
> CONFIG_MMC_SUNXI_SLOT_EXTRA=2
> CONFIG_R_I2C_ENABLE=y
> +CONFIG_SPL_SUNXI_LED_STATUS=y
> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=356
> +# CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_HIGH is not set
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> CONFIG_SPL_I2C=y
> CONFIG_SPL_SYS_I2C_LEGACY=y
> diff --git a/configs/tanix_tx1_defconfig b/configs/tanix_tx1_defconfig
> index 1bd167ce0f6..03b18701859 100644
> --- a/configs/tanix_tx1_defconfig
> +++ b/configs/tanix_tx1_defconfig
> @@ -14,6 +14,8 @@ CONFIG_MACH_SUN50I_H616=y
> CONFIG_SUNXI_DRAM_H616_LPDDR3=y
> CONFIG_MMC_SUNXI_SLOT_EXTRA=2
> CONFIG_R_I2C_ENABLE=y
> +CONFIG_SPL_SUNXI_LED_STATUS=y
> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=231
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> CONFIG_SPL_I2C=y
> CONFIG_SPL_SYS_I2C_LEGACY=y
> --
> 2.43.0
>
--
Paul Kocialkowski,
Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/
Expert in multimedia, graphics and embedded hardware support with Linux.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2026-04-29 13:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 9:28 [PATCH v2 0/3] Funxi: Fix and extend SPL power LED support Andre Przywara
2026-04-29 9:28 ` [PATCH v2 1/3] sunxi: spl: fix SPL_SUNXI_LED active low configuration Andre Przywara
2026-04-29 9:49 ` Quentin Schulz
2026-04-29 13:07 ` Paul Kocialkowski
2026-04-29 9:28 ` [PATCH v2 2/3] sunxi: configs: enable power LEDs on 32-bit boards Andre Przywara
2026-04-29 13:08 ` Paul Kocialkowski
2026-04-29 9:28 ` [PATCH v2 3/3] sunxi: configs: enable power LEDs on 64-bit boards Andre Przywara
2026-04-29 13:08 ` Paul Kocialkowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afICzqv7jawLFjyB@shepard \
--to=paulk@sys-base.io \
--cc=andre.przywara@arm.com \
--cc=jernej.skrabec@gmail.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=quentin.schulz@cherry.de \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.