Re: [PATCH v2 5/6] tests: Check whether the I2C master flag is set

[Arun Menon <armenon@redhat.com>]

Hi,

On Wed, Apr 29, 2026 at 12:17:42PM +0000, Stefan Berger wrote:
> Replace the 'once' variable with a check for whether the master flag is
> set so that the flag can be set when needed.
> 
> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> ---
>  tests/qtest/qtest_aspeed.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/qtest/qtest_aspeed.c b/tests/qtest/qtest_aspeed.c
> index f6da9adea9..7bf5abb9be 100644
> --- a/tests/qtest/qtest_aspeed.c
> +++ b/tests/qtest/qtest_aspeed.c
> @@ -15,18 +15,21 @@
>  #include "qtest_aspeed.h"
>  #include "hw/i2c/aspeed_i2c.h"
>  
> +static bool aspeed_i2c_is_master_enabled(QTestState *s, uint32_t baseaddr)
> +{
> +    return qtest_readl(s, baseaddr + A_I2CC_FUN_CTRL) & A_I2CD_MASTER_EN;
> +}
> +
>  static void aspeed_i2c_startup(QTestState *s, uint32_t baseaddr,
>                                 uint8_t slave_addr, uint8_t reg)
>  {
>      uint32_t v;
> -    static int once;
>  
> -    if (!once) {
> +    if (!aspeed_i2c_is_master_enabled(s, baseaddr)) {
>          /* one time: enable master */
>         qtest_writel(s, baseaddr + A_I2CC_FUN_CTRL, 0);
>         v = qtest_readl(s, baseaddr + A_I2CC_FUN_CTRL) | A_I2CD_MASTER_EN;
>         qtest_writel(s, baseaddr + A_I2CC_FUN_CTRL, v);
> -       once = 1;
>      }
>  
>      /* select device */
> -- 
> 2.43.0
> 

Reviewed-by: Arun Menon <armenon@redhat.com>

Regards,
Arun Menon