From: Li Wang <li.wang@linux.dev>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] lib: tst_test: tst_reinit() abort when already initialized
Date: Thu, 30 Apr 2026 18:34:24 +0800 [thread overview]
Message-ID: <afMwMO1yTBGDLQJc@linux.dev> (raw)
In-Reply-To: <20260430091956.10915-1-chrubis@suse.cz>
On Thu, Apr 30, 2026 at 11:19:56AM +0200, Cyril Hrubis wrote:
> Calling tst_reinit() when library is already initialized or calling it
> for a second time is always mistake. With that we silenty drop the old
> IPC region, that may have contained test results and there are likely
> other problems possibly caused by initializing the test library twice.
>
> To fix that this patch adds tst_brk() that abort the test if we call
> tst_reinit() with already initialized test library.
>
> Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
Reviewed-by: Li Wang <li.wang@linux.dev>
The patch itself looks good, I'm just wondering how you found
this issue, was it called twice somewhere/in a test?
--
Regards,
Li Wang
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-04-30 10:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 9:19 [LTP] [PATCH] lib: tst_test: tst_reinit() abort when already initialized Cyril Hrubis
2026-04-30 10:19 ` Andrea Cervesato via ltp
2026-04-30 10:34 ` Li Wang [this message]
2026-04-30 12:53 ` Cyril Hrubis
2026-05-07 1:00 ` Li Wang
2026-05-07 6:58 ` Cyril Hrubis
2026-05-07 8:41 ` Li Wang
2026-05-07 9:02 ` Li Wang
2026-05-07 9:08 ` Cyril Hrubis
2026-05-07 9:13 ` Li Wang
2026-04-30 11:38 ` [LTP] " linuxtestproject.agent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afMwMO1yTBGDLQJc@linux.dev \
--to=li.wang@linux.dev \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.