From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Fernando Fernandez Mancera <fmancera@suse.de>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
jeremy@azazel.net, phil@nwl.cc
Subject: Re: [PATCH nf v4] netfilter: nft_bitwise: fix dst corruption in same register shifts
Date: Thu, 30 Apr 2026 13:46:49 +0200 [thread overview]
Message-ID: <afNBKf1YJYKG14_c@chamomile> (raw)
In-Reply-To: <afL66Hdt560a2EgL@strlen.de>
On Thu, Apr 30, 2026 at 08:47:10AM +0200, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > And probably nft_byteorder needs something similar to check for
> > partial overlaps too for sreg and dreg. Also nft_lookup.
>
> nft_lookup might be fine. Key could be larger than result, and vice
> versa. Userspace could be chaining lookups too. I think we should not
> restrict nft_lookup.
Agreed.
prev parent reply other threads:[~2026-04-30 11:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 9:21 [PATCH nf v4] netfilter: nft_bitwise: fix dst corruption in same register shifts Fernando Fernandez Mancera
2026-04-30 6:11 ` Pablo Neira Ayuso
2026-04-30 6:26 ` Pablo Neira Ayuso
2026-04-30 6:32 ` Pablo Neira Ayuso
2026-04-30 6:47 ` Florian Westphal
2026-04-30 11:46 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afNBKf1YJYKG14_c@chamomile \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=fmancera@suse.de \
--cc=fw@strlen.de \
--cc=jeremy@azazel.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.