From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Lee Jones <lee@kernel.org>, Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Thomas Gleixner <tglx@kernel.org>,
"Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH] mfd: wm8994: remove dead legacy-gpio code
Date: Thu, 30 Apr 2026 13:06:51 +0100 [thread overview]
Message-ID: <afNF26Vffan919G1@opensource.cirrus.com> (raw)
In-Reply-To: <20260427143437.3059210-1-arnd@kernel.org>
On Mon, Apr 27, 2026 at 04:34:27PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The old-style gpio handling in wm8994 came from a commit 7c8844481a1c
> ("mfd: wm8994: Emulate level triggered interrupts if required") in
> linux-3.11, but nothing in the kernel ever set the 'irq_gpio' member
> in the wm8994_pdata structure, so this was always dead code.
>
> Remove it now to reduce the dependency on the legacy gpio interfaces.
>
> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
wm8994 predates me a little so not really sure if this had users
out of tree or not. But the part is probably old enough we can
risk it here.
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2026-04-30 12:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 14:34 [PATCH] mfd: wm8994: remove dead legacy-gpio code Arnd Bergmann
2026-04-30 11:17 ` Linus Walleij
2026-04-30 12:06 ` Charles Keepax [this message]
2026-05-07 19:46 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afNF26Vffan919G1@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@kernel.org \
--cc=jirislaby@kernel.org \
--cc=lee@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.