From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90C46401A38 for ; Thu, 30 Apr 2026 13:15:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777554913; cv=none; b=bilBFCqOH7zjrkozrT9ZMLQMW6ylFRMER13myWIYZ0gSdwhTqOWYwT/RAWH82bDrYDDt406qynqOGdQIIsf9A/8Wq2ZCPs5vSGXw53/ap9luAI3VVYjJvWxwBWLmcvatr7Ls0DO8el5LEEy48K4hqquPA7z8Lkc10e8D33OMNAI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777554913; c=relaxed/simple; bh=k6Ky8SekzqlEMWe2IfF4o9e521vL5c/R7nKtlYixpPs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=c1yc1VvPetGT9ekRpUWRyUKbUn2slEMfhYGVhfbjMMRgC16fxInlCT2I0/lVXnfCFpV+K4k89+ABkL1HYqLD3hLs4Rl3BmKeL3+6UNZcIWSy39Nmk3QJW6Od6xe6+i83HxU/rEm6w+4FjVIw2sZgCQvcRgWBIqbYtbsPhqdcBT0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=lrVUzEQt; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="lrVUzEQt" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-488d2079582so9328165e9.2 for ; Thu, 30 Apr 2026 06:15:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1777554910; x=1778159710; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Q14Nfv+UEqF4wGTpTXYwRmNvMzztXWMPU3JKrPL0wNU=; b=lrVUzEQtwJpa8qpxe9jJFywb/+BO0GoRPCbpCwEf54ypCQeIe3F5dBdDaAkaFyp/1d FTDV5JhRQfnIHvurTg30BV5rZhAZL9IcYQoa9wYfuG9xCXa1oeZGD2LhAzcEZaoI/n5p jn26GWfz/0ezA75/YJMtjsGGpmGWNZHDZ2RwelsRskWa5F4TFaaxby8s3aNoEjspARYK kHTHXPYmuvCBcNM4/ufjVq2QiTmJuoYdRiRvct5jNY45LUxmQMBnzUU4iS35WpHZRcSY oEUhJOH3PSru1Qr8rH4cqkBhqSj+P3+Q7KsfRmGHY136VRyQopaS7sGIcsUldQ5DHja7 MQ2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777554910; x=1778159710; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q14Nfv+UEqF4wGTpTXYwRmNvMzztXWMPU3JKrPL0wNU=; b=Cr36DcHtnso6LfktAdp5VlhNJ6L5p7ouDv35LipSFrA05+hmnKzlnQ4WYTFbpIRGn7 gFnfL0LgEkLimvaeOR/lY3VrU1bU/g3+RmHH6x0oTm2ZzUMUmrahhz9urgZY2wnuvAVy +SH6AYmX5EK1wSWQg8GXw7nV+7MSJTmXI8aHiKYWEN41spUjsBxxAz+goyDFpWQoUSNt nbF2WFnjWbt1ZcB/9O1d/MOF9Ldmk5CyUwOlEU9Vjr78ZnVDEwSaviICnPubG3fTKE0Y aPASYZEW+X//Eyc5wxkfTg8qlc/ouM6zo3PjTC7/HZQU1R6cJnuHKRN6RiWvrAt5Ql1h zb6A== X-Forwarded-Encrypted: i=1; AFNElJ8b69JzG9I2/LZvORvIerdWSOHexx/vdw0GV9i2F1h4dO9i+Uc8b/fir/feyuguubuRAUd+MbBYvXM=@lists.linux.dev X-Gm-Message-State: AOJu0YysfSBzZMSgEZULhzvQGr3/zKTBNHHMGv/Y6YK5/uGjKf0FnKME gYtSLEM+vSSGvubRFW5cGxBAPOu2Y/IKTC+Cc26jGz4+j6KSmiPw6BrQDYMc21Pe2kw= X-Gm-Gg: AeBDiesyTSmxBG8slvoK9hD5R6qxJrOLcqzQ8uswxPRdAhQM7greWOfoDuZGpxzVAfR PsEJ3U5ekB5ch8pvkaYydAh5xVOc89ZYuTtoZzWojrl/sWfatDpzOW3fXZ6GwBTOcqZ/I36QWU/ aoLp1iLT/wH0zo93GfgQUPcbLFsukq/unXrLUTC1d+dPsdEX3vDeul/lDsVR9Ov4MEx3xd259DO kSFl0qw+8q5ysCcdWGZAlD0vB827sr/nMKQGMpBJIZrjLfLwNHH5OOHBSDMa40DhI37ToHLRuiq YbpDIDk1PZAVAreFM5vlDThzJtUE0ebpJUJAJskelhx/DagqYkCX0q/tiJ+594AYs7TbLgLr6xe yGbAHP6gqcMkBdd7lAW/hFN73bNRS9S3PW/mrpjqvZ0yqH628EVqzlFbi9CULyXD4Y0wlTA+kS+ LdhNlFkifr7/ZdQ+LzVyDxgQCtAoIYmbebj4py087RkPSL0+EY56UFSuXaVXUrgVOkfcznJJBlH uliNXLCTbl/2a7eoQRYSwwcVg== X-Received: by 2002:a05:600c:c0db:b0:489:284:44ab with SMTP id 5b1f17b1804b1-48a83f6b306mr35501805e9.12.1777554909754; Thu, 30 Apr 2026 06:15:09 -0700 (PDT) Received: from localhost (p200300f65f114e0859f76ff87a50eb14.dip0.t-ipconnect.de. [2003:f6:5f11:4e08:59f7:6ff8:7a50:eb14]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-447b3d47ff1sm13921904f8f.6.2026.04.30.06.15.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2026 06:15:08 -0700 (PDT) Date: Thu, 30 Apr 2026 15:15:07 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Markus Schneider-Pargmann Cc: Michael Grzeschik , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marc Kleine-Budde , Vincent Mailhol , Krzysztof Halasa , Johannes Berg , Steffen Klassert , David Dillow , Ion Badulescu , Mark Einon , Rasesh Mody , GR-Linux-NIC-Dev@marvell.com, Manish Chopra , Potnuri Bharat Teja , Denis Kirjanov , Jijie Shao , Jian Shen , Cai Huoqing , Fan Gong , Tony Nguyen , Przemek Kitszel , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Mark Bloch , Ido Schimmel , Petr Machata , Yibo Dong , Simon Horman , Heiner Kallweit , nic_swsd@realtek.com, Jiri Pirko , Francois Romieu , Daniele Venzano , Samuel Chessman , Jiawen Wu , Mengyuan Lou , Kevin Curtis , Arend van Spriel , Stanislav Yakovlev , Richard Cochran , Kees Cook , Thomas Gleixner , Thomas Fourier , Ingo Molnar , Kory Maincent , Zilin Guan , Marco Crivellari , Vadim Fedorenko , Jacob Keller , Philipp Stanner , Bjorn Helgaas , Yeounsu Moon , Denis Benato , Yonglong Liu , Andy Shevchenko , Yicong Hui , Randy Dunlap , MD Danish Anwar , Nathan Chancellor , Sai Krishna , Ethan Nelson-Moore , Larysa Zaremba , Joe Damato , Double Lo , Colin Ian King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-can@vger.kernel.org, linux-parisc@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@corigine.com, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com Subject: Re: [PATCH net-next] net: Consistently define pci_device_ids using named initializers Message-ID: References: <20260428171845.2288395-2-u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: brcm80211@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6b5ffjhgb6zy7r2y" Content-Disposition: inline In-Reply-To: --6b5ffjhgb6zy7r2y Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH net-next] net: Consistently define pci_device_ids using named initializers MIME-Version: 1.0 Hello Markus, On Thu, Apr 30, 2026 at 10:55:14AM +0200, Markus Schneider-Pargmann wrote: > On Tue Apr 28, 2026 at 7:18 PM CEST, Uwe Kleine-K=F6nig (The Capable Hub)= wrote: > > diff --git a/drivers/net/can/m_can/m_can_pci.c b/drivers/net/can/m_can/= m_can_pci.c > > index eb31ed1f9644..cb9335c1d3ea 100644 > > --- a/drivers/net/can/m_can/m_can_pci.c > > +++ b/drivers/net/can/m_can/m_can_pci.c > > @@ -183,9 +183,9 @@ static SIMPLE_DEV_PM_OPS(m_can_pci_pm_ops, > > m_can_pci_suspend, m_can_pci_resume); > > =20 > > static const struct pci_device_id m_can_pci_id_table[] =3D { > > - { PCI_VDEVICE(INTEL, 0x4bc1), M_CAN_CLOCK_FREQ_EHL, }, > > - { PCI_VDEVICE(INTEL, 0x4bc2), M_CAN_CLOCK_FREQ_EHL, }, > > - { } /* Terminating Entry */ > > + { PCI_VDEVICE(INTEL, 0x4bc1), .driver_data =3D M_CAN_CLOCK_FREQ_EHL, = }, > > + { PCI_VDEVICE(INTEL, 0x4bc2), .driver_data =3D M_CAN_CLOCK_FREQ_EHL, = }, > > + { } /* terminating entry */ >=20 > M_CAN_CLOCK_FREQ_EHL is basically hardcoded for all PCI devices since > 2020. I don't think we need this driver data at all and can just drop it > and use M_CAN_CLOCK_FREQ_EHL directly in the code for the frequency. > Once a real new PCI device gets added we can see if and what driver_data > is needed. Sounds like a nice *separate* change, right? Best regards Uwe --6b5ffjhgb6zy7r2y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmnzVdgACgkQj4D7WH0S /k4x3Af/edtfz9YYPFE6xum2g4TegCtLIvKw++0KDUAoyqpgkttjiVhQP2pkII1I bwoXEDLgA701tfOm6K4xaBwmjr22fTEMmwqGBUUV9kbxJkZTOYaAvGL9vZUhumqW aON4lzwvfmfJ4n1Nk/YWjSE0QmjI9PG7aoUCczzIPsEamTrS3xLh7OpHvF2bshFv 8t879m4kyInFizFXvDm3Pb+7WfqIwJHbJBKFtf3yy5ZlAf4JxFccVoOC3ygeZaz7 2S+yew8q9RxoAdReZzT/aUjlxkf0z4CmHidC1JcBK8qT/tAsE7w86uaDZOy5/ZKz gpkzwoU/cOxmGkcr+S/smN1/kcOCJg== =Kvic -----END PGP SIGNATURE----- --6b5ffjhgb6zy7r2y-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FD8ACD3423 for ; Thu, 30 Apr 2026 16:53:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 3836784EBE; Thu, 30 Apr 2026 16:53:32 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 5zTL9GBmp7Jt; Thu, 30 Apr 2026 16:53:31 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org A43DE84EB3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1777568011; bh=Q14Nfv+UEqF4wGTpTXYwRmNvMzztXWMPU3JKrPL0wNU=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=qE19b33I2oDXiIxIOQKu4zx8XHwvMzot3O73h6ed8O8daKMF0H8tcsn7RyOLIXKTe faaz9r17oymeSmIX6znVazkguR3jaVg6GOMIpU6aP/xCczlKeJwgV4Wq3/igIed22Y A3SNUr5XcGr40MOrQpdN6U+8GyDsYWCTlrPFhVRKHqhEFB0+vfBk7Hy2nSgNfyoOwo Wt68elRJSOcF5qjXCPvRSi8pkW2ZrAlinGyqDMv4tSNWekfb8LzmlfG/+KyiiApeUs ioTlknY0oYw8MGVuRaSTrodhqQelc+ThpgwjTV9cmmmgGpRwRTiPf8VkszUkdx4ZmU KDW/TOXDOomFw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id A43DE84EB3; Thu, 30 Apr 2026 16:53:31 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists1.osuosl.org (Postfix) with ESMTP id 95657192 for ; Thu, 30 Apr 2026 13:15:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 7B2F94078E for ; Thu, 30 Apr 2026 13:15:13 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id ZepFpRk_RPub for ; Thu, 30 Apr 2026 13:15:12 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::334; helo=mail-wm1-x334.google.com; envelope-from=ukleinek@baylibre.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 59C844078B DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 59C844078B Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by smtp2.osuosl.org (Postfix) with ESMTPS id 59C844078B for ; Thu, 30 Apr 2026 13:15:11 +0000 (UTC) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-488d2079582so9328205e9.2 for ; Thu, 30 Apr 2026 06:15:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777554910; x=1778159710; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q14Nfv+UEqF4wGTpTXYwRmNvMzztXWMPU3JKrPL0wNU=; b=AFgvg+Dg7CeN2x8+97hUTo+/Z/tSmNDAh49PfGAFDjqj6eu8TqO1SBykufEDiqqwBN MMUE95fYObOe7FR/VAez/AFGPQ/lISHlxL8liFZuHVhXupTXohS/tPGn6TvQzr3Ar9PQ w7JBWFsR+QTZC6iseOPkYSep/g8TIcEZmnNUJmFL3kpv4FUBT+YDuDb25/KMe5+Liaqa Z3XvOeg+Xy0ts1mGZvBfaSCHC++f9aVduybBLfS2dDs8GzTMk8cbULZOC4MM71SNg3Jc DNlt7G/wzgNVIFLtiVeaxJMdcljC26pwmduLdCV01wigqKekIchNtXFDqqrHKNzTeZ8a a4eA== X-Forwarded-Encrypted: i=1; AFNElJ+7znngOJ+FmFafmGuDzX+ls+enaEi4zNbnqqYZVKq0NDLi29N8GQXVwsYv3NyWB53gv6smlnStd8w59bWu4LU=@lists.osuosl.org X-Gm-Message-State: AOJu0YzdtLPImWDgzZZjXFAkX4AxqDqdKzIWl74VixN3ZChaMRRckblh hWr4tsoG50dfakEUNHwNM7V+8og46RnbVFvjuEkslY7BNj1ujm87POF2m/Pu4v3Pq3I= X-Gm-Gg: AeBDiet8ibbimljiDTJ6FcLD+08IUSdMmhY9kvGNxRCRMP671UJK6zEzEO+4DUd/SZ5 Bi3/85qOwjYlS+cB+tA/FGUGq+AHNxhhUyCUoyfR2CFmj/X6aJHZlAbz/kihqGU0ptWp0+wyb70 Sr1liqFxx1OoE31RV4VL86cqVQuClKMEiQ6ntmxvTWaX/Rt4q8BiWqHb92hQSYvrH9ERGP9q93c m0xAV47/kX6foVCEp6BEnFL7/eq3cWSkzZFp+otmLC+/AoOc0+XpQqVgw7qhlVdUBYb6sqo/iG3 U2T/uG8yVLTyzOKTDbvamutbNbJOVg4HQqDuMvTEBG/1K670s+Oolp6NgPPMs0/WgSk7VT1eZXo g6sW90kyEYH9a58U5JTZz2+c6xE3RN1CHhn7DysnNPNPny+Cu5z5stNDeLydXlFb4plbn5mbZZ0 PYDCGsS1+47IrOyleu0/EqkA8uC4AIBG+ibW1/VC86YxhlY7CwjkpF/rxEH682q0XcMG2MQ70Y3 YQ/2F4Sl95zguctg8vEv8JVtQ== X-Received: by 2002:a05:600c:c0db:b0:489:284:44ab with SMTP id 5b1f17b1804b1-48a83f6b306mr35501805e9.12.1777554909754; Thu, 30 Apr 2026 06:15:09 -0700 (PDT) Received: from localhost (p200300f65f114e0859f76ff87a50eb14.dip0.t-ipconnect.de. [2003:f6:5f11:4e08:59f7:6ff8:7a50:eb14]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-447b3d47ff1sm13921904f8f.6.2026.04.30.06.15.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2026 06:15:08 -0700 (PDT) Date: Thu, 30 Apr 2026 15:15:07 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Markus Schneider-Pargmann Message-ID: References: <20260428171845.2288395-2-u.kleine-koenig@baylibre.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6b5ffjhgb6zy7r2y" Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Thu, 30 Apr 2026 16:53:24 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1777554910; x=1778159710; darn=lists.osuosl.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Q14Nfv+UEqF4wGTpTXYwRmNvMzztXWMPU3JKrPL0wNU=; b=FsIXK/ebPrNMD5iPiy4mp57+AEjsuba36Blu64IePyewV5jc+AbuhYqpvMstr3bPxA V1CzK85rX0QHr8LRDBqfUAptdL52pqgOTm+Y7EL68XHnMVNWUAXzZanhU1cWYQLLujDq 8NbgTT+cR1V9te0TZ6fZoVYPbWUHPa0pXDpxcA0ttfHseZ+kedsUkl8sVrArGjubhTsJ frIkHYVEX5ivW5EGkUbIrVLtdvrAKoRtop+VqrQ2qv1NP7OXahncG2QXFgK1fpmGR+/h WeUatbQl2VFnEKtJsfAY75HKSllZr4JWswvh5Btn2BTefsv660ht+VpMnTGQKNOOh9nk sDxA== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=none (p=none dis=none) header.from=baylibre.com X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.a=rsa-sha256 header.s=20251104 header.b=FsIXK/eb Subject: Re: [Intel-wired-lan] [PATCH net-next] net: Consistently define pci_device_ids using named initializers X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Cochran , Marco Crivellari , Randy Dunlap , Yonglong Liu , Kees Cook , linux-wireless@vger.kernel.org, Larysa Zaremba , Joe Damato , brcm80211@lists.linux.dev, Daniele Venzano , Eric Dumazet , Tony Nguyen , MD Danish Anwar , Samuel Chessman , Fan Gong , Mengyuan Lou , Kevin Curtis , Ingo Molnar , Ion Badulescu , Michael Grzeschik , Yeounsu Moon , Manish Chopra , Colin Ian King , Przemek Kitszel , Thomas Fourier , Sai Krishna , Denis Kirjanov , intel-wired-lan@lists.osuosl.org, linux-parisc@vger.kernel.org, Jacob Keller , Jakub Kicinski , Paolo Abeni , Steffen Klassert , Stanislav Yakovlev , linux-rdma@vger.kernel.org, Arend van Spriel , nic_swsd@realtek.com, Jiri Pirko , Ethan Nelson-Moore , Philipp Stanner , Ido Schimmel , Potnuri Bharat Teja , Double Lo , linux-can@vger.kernel.org, Nathan Chancellor , Jiawen Wu , Cai Huoqing , Mark Einon , Bjorn Helgaas , Zilin Guan , Yibo Dong , Andy Shevchenko , Petr Machata , Kory Maincent , brcm80211-dev-list.pdl@broadcom.com, GR-Linux-NIC-Dev@marvell.com, Vadim Fedorenko , Leon Romanovsky , Denis Benato , Rasesh Mody , netdev@vger.kernel.org, oss-drivers@corigine.com, Vincent Mailhol , Mark Bloch , linux-kernel@vger.kernel.org, Tariq Toukan , Jian Shen , Jijie Shao , Andrew Lunn , Thomas Gleixner , Simon Horman , Yicong Hui , Marc Kleine-Budde , Johannes Berg , Heiner Kallweit , Saeed Mahameed , "David S. Miller" , Krzysztof Halasa Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" --6b5ffjhgb6zy7r2y Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH net-next] net: Consistently define pci_device_ids using named initializers MIME-Version: 1.0 Hello Markus, On Thu, Apr 30, 2026 at 10:55:14AM +0200, Markus Schneider-Pargmann wrote: > On Tue Apr 28, 2026 at 7:18 PM CEST, Uwe Kleine-K=F6nig (The Capable Hub)= wrote: > > diff --git a/drivers/net/can/m_can/m_can_pci.c b/drivers/net/can/m_can/= m_can_pci.c > > index eb31ed1f9644..cb9335c1d3ea 100644 > > --- a/drivers/net/can/m_can/m_can_pci.c > > +++ b/drivers/net/can/m_can/m_can_pci.c > > @@ -183,9 +183,9 @@ static SIMPLE_DEV_PM_OPS(m_can_pci_pm_ops, > > m_can_pci_suspend, m_can_pci_resume); > > =20 > > static const struct pci_device_id m_can_pci_id_table[] =3D { > > - { PCI_VDEVICE(INTEL, 0x4bc1), M_CAN_CLOCK_FREQ_EHL, }, > > - { PCI_VDEVICE(INTEL, 0x4bc2), M_CAN_CLOCK_FREQ_EHL, }, > > - { } /* Terminating Entry */ > > + { PCI_VDEVICE(INTEL, 0x4bc1), .driver_data =3D M_CAN_CLOCK_FREQ_EHL, = }, > > + { PCI_VDEVICE(INTEL, 0x4bc2), .driver_data =3D M_CAN_CLOCK_FREQ_EHL, = }, > > + { } /* terminating entry */ >=20 > M_CAN_CLOCK_FREQ_EHL is basically hardcoded for all PCI devices since > 2020. I don't think we need this driver data at all and can just drop it > and use M_CAN_CLOCK_FREQ_EHL directly in the code for the frequency. > Once a real new PCI device gets added we can see if and what driver_data > is needed. Sounds like a nice *separate* change, right? Best regards Uwe --6b5ffjhgb6zy7r2y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmnzVdgACgkQj4D7WH0S /k4x3Af/edtfz9YYPFE6xum2g4TegCtLIvKw++0KDUAoyqpgkttjiVhQP2pkII1I bwoXEDLgA701tfOm6K4xaBwmjr22fTEMmwqGBUUV9kbxJkZTOYaAvGL9vZUhumqW aON4lzwvfmfJ4n1Nk/YWjSE0QmjI9PG7aoUCczzIPsEamTrS3xLh7OpHvF2bshFv 8t879m4kyInFizFXvDm3Pb+7WfqIwJHbJBKFtf3yy5ZlAf4JxFccVoOC3ygeZaz7 2S+yew8q9RxoAdReZzT/aUjlxkf0z4CmHidC1JcBK8qT/tAsE7w86uaDZOy5/ZKz gpkzwoU/cOxmGkcr+S/smN1/kcOCJg== =Kvic -----END PGP SIGNATURE----- --6b5ffjhgb6zy7r2y--