Re: [PATCH] selftests: cgroup: Add basic tests for rdma controller

["Michal Koutný" <mkoutny@suse.com>]

[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]

Hello.

On Thu, Apr 30, 2026 at 04:43:10PM +0800, Tao Cui <cuitao@kylinos.cn> wrote:
> +struct rdmacg_test {
> +	int (*fn)(const char *root);
> +	const char *name;
> +} tests[] = {
> +	T(test_rdmacg_max_read),
> +	T(test_rdmacg_max_write_nonexistent),
> +	T(test_rdmacg_max_write_invalid),
> +	T(test_rdmacg_max_device_limits),
> +	T(test_rdmacg_max_hierarchy),

IIUC, these are tests for proper parsing of the limits but not so useful
wrt RDMA controller (test_rdmacg_max_read has apparently little use).

I see that you try to work with a first found device -- if that's
available, it'd be good to have a test that checks whether respective
rdma.current-s respond to object allocations.


As I am looking at test_hugetlb_memcg.c that does only simple
testing of the .current would be sufficient, not sure how difficult
would be to implement a test for actual limit enforcement (but would be
nice too).

I.e. -- these would be good test to validate basic behavior of the
controller.

Thanks,
Michal

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 265 bytes --]