From: Joe Damato <joe@dama.to>
To: Dimitri Daskalakis <dimitri.daskalakis1@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shuah Khan <shuah@kernel.org>,
Dimitri Daskalakis <daskald@meta.com>, David Wei <dw@davidwei.uk>,
Dragos Tatulea <dtatulea@nvidia.com>,
Vishwanath Seshagiri <vishs@fb.com>,
Pavel Begunkov <asml.silence@gmail.com>,
Simon Horman <horms@kernel.org>,
Pavan Chebbi <pavan.chebbi@broadcom.com>,
Michael Chan <michael.chan@broadcom.com>,
Gal Pressman <gal@nvidia.com>,
linux-kselftest@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] selftests: drv-net: Enable ntuple-filters if supported
Date: Thu, 30 Apr 2026 12:36:51 -0700 [thread overview]
Message-ID: <afOvUznmpTEPBJrS@devvm20253.cco0.facebook.com> (raw)
In-Reply-To: <20260430165217.3700469-1-dimitri.daskalakis1@gmail.com>
On Thu, Apr 30, 2026 at 09:52:17AM -0700, Dimitri Daskalakis wrote:
> From: Dimitri Daskalakis <daskald@meta.com>
>
> Certain devices which support ntuple-filters do not enable the feature
> by default. The existing tests will skip (if they check for the feature),
> or fail if they blindly attempt to install rules. Therefore, attempt to turn
> on ntuple-filters if the device supports them.
>
> Signed-off-by: Dimitri Daskalakis <daskald@meta.com>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> tools/testing/selftests/drivers/net/gro.py | 10 ++++++++++
> tools/testing/selftests/drivers/net/hw/gro_hw.py | 10 ++++++++++
> tools/testing/selftests/drivers/net/hw/iou-zcrx.py | 12 ++++++++++++
> tools/testing/selftests/drivers/net/hw/ntuple.py | 5 ++++-
> tools/testing/selftests/drivers/net/hw/rss_ctx.py | 7 ++++---
> 5 files changed, 40 insertions(+), 4 deletions(-)
I suppose a future cleanup might be able to add a generic helper for this for
all of the ethtool settings (tx-udp-segmentation, ntuple, etc) to
EthtoolFamily or something?
That said:
Reviewed-by: Joe Damato <joe@dama.to>
next prev parent reply other threads:[~2026-04-30 19:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 16:52 [PATCH net-next] selftests: drv-net: Enable ntuple-filters if supported Dimitri Daskalakis
2026-04-30 19:36 ` Joe Damato [this message]
2026-05-02 0:20 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2026-04-27 16:58 Dimitri Daskalakis
2026-04-27 22:56 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afOvUznmpTEPBJrS@devvm20253.cco0.facebook.com \
--to=joe@dama.to \
--cc=andrew+netdev@lunn.ch \
--cc=asml.silence@gmail.com \
--cc=daskald@meta.com \
--cc=davem@davemloft.net \
--cc=dimitri.daskalakis1@gmail.com \
--cc=dtatulea@nvidia.com \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=shuah@kernel.org \
--cc=vishs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.