All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Ackerley Tng <ackerleytng@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	David Hildenbrand <david@kernel.org>,
	kvm@vger.kernel.org,  linux-kernel@vger.kernel.org,
	Yosry Ahmed <yosry@kernel.org>,  Marc Zyngier <maz@kernel.org>,
	Oliver Upton <oupton@kernel.org>,
	 Tianrui Zhao <zhaotianrui@loongson.cn>,
	Bibo Mao <maobibo@loongson.cn>,
	 Huacai Chen <chenhuacai@kernel.org>,
	Anup Patel <anup@brainfault.org>,
	 Christian Borntraeger <borntraeger@linux.ibm.com>,
	Janosch Frank <frankja@linux.ibm.com>,
	 Claudio Imbrenda <imbrenda@linux.ibm.com>
Subject: Re: [RFC PATCH 2/5] KVM: guest_memfd: Move gmem function declarations to dedicated guest_memfd.h
Date: Thu, 30 Apr 2026 14:38:50 -0700	[thread overview]
Message-ID: <afPL6uCXVAPb_t_Y@google.com> (raw)
In-Reply-To: <CAEvNRgHqLcdO5j1X-nXXSjewOmnCDJmHtmPh=1jtQ3Tkf7+HMw@mail.gmail.com>

On Thu, Apr 30, 2026, Ackerley Tng wrote:
> Sean Christopherson <seanjc@google.com> writes:
> 
> > Extract the gmem function declarations out of kvm_mm.h and into a dedicated
> > header, guest_memfd.h.  This will allow creating a MAINTAINERS entry for
> > guest_memfd without having to rely on content pattern matching.
> >
> 
> This also trims kvm_mm.h, which makes it easier to look stuff
> up. Thanks!
> 
> Shall we do something similar for include/linux/kvm_host.h?

LOL, we can try.  :-)

Not for linux/kvm_host.h, but I've tried to carve up x86's asm/kvm_host.h on
multiple occassions, and have failed miserably every time.

But linux/kvm_host.h is probably less intertwined?  Though I think we should
split out headers if and only if there's substantial .c content as well.  E.g.
if we add kvm_memslots.h, then I would also want kvm_memslots.c, because having
a dedicated headers while leaving the vast majority of memslots code in the
common kvm_main.c would be kludgy.

  reply	other threads:[~2026-04-30 21:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-28 17:15 [RFC PATCH 0/5] MAINTAINERS: KVM tweaks and additions Sean Christopherson
2026-04-28 17:15 ` [RFC PATCH 1/5] MAINTAINERS: Add kvm-x86 tree to KVM x86 entries Sean Christopherson
2026-04-28 17:15 ` [RFC PATCH 2/5] KVM: guest_memfd: Move gmem function declarations to dedicated guest_memfd.h Sean Christopherson
2026-04-28 19:26   ` David Hildenbrand (Arm)
2026-04-30 19:07   ` Ackerley Tng
2026-04-30 21:38     ` Sean Christopherson [this message]
2026-04-28 17:15 ` [RFC PATCH 3/5] MAINTAINERS: Add an entry for KVM's guest_memfd Sean Christopherson
2026-04-28 19:27   ` David Hildenbrand (Arm)
2026-04-30 19:08   ` Ackerley Tng
2026-04-30 21:33     ` Sean Christopherson
2026-04-28 17:15 ` [RFC PATCH 4/5] MAINTAINERS: Add David H. as a KVM guest_memfd reviewer Sean Christopherson
2026-04-28 19:27   ` David Hildenbrand (Arm)
2026-04-30 19:08     ` Ackerley Tng
2026-04-28 17:15 ` [RFC PATCH 5/5] MAINTAINERS: Add myself (Sean) as a reviewer in the main KVM entry Sean Christopherson
2026-04-28 19:30   ` David Hildenbrand (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afPL6uCXVAPb_t_Y@google.com \
    --to=seanjc@google.com \
    --cc=ackerleytng@google.com \
    --cc=anup@brainfault.org \
    --cc=borntraeger@linux.ibm.com \
    --cc=chenhuacai@kernel.org \
    --cc=david@kernel.org \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maobibo@loongson.cn \
    --cc=maz@kernel.org \
    --cc=oupton@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=yosry@kernel.org \
    --cc=zhaotianrui@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.