From: Yao Zi <me@ziyao.cc>
To: Michal Simek <michal.simek@amd.com>, <u-boot@lists.denx.de>,
<git@amd.com>
Cc: Leo <ycliang@andestech.com>, Rick Chen <rick@andestech.com>,
Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH] riscv: Exclude ACLINT for TARGET_XILINX_MBV
Date: Fri, 1 May 2026 10:33:38 +0000 [thread overview]
Message-ID: <afSBgg0wWVBn5gju@pie> (raw)
In-Reply-To: <75160eb268d7a445e8483b357f7814bef30b12d4.1777550306.git.michal.simek@amd.com>
On Thu, Apr 30, 2026 at 01:58:28PM +0200, Michal Simek wrote:
> The Xilinx MicroBlaze V platform does not have an ACLINT (Advanced
> Core Local Interruptor) hardware block. The timer functionality is
> provided through a different mechanism.
>
> Exclude both RISCV_ACLINT and SPL_RISCV_ACLINT from being implied
> for TARGET_XILINX_MBV while keeping the default behavior for other
> generic RISC-V targets that do have ACLINT hardware.
>
> spl/u-boot-spl: all -1382 data -360 rodata -200 text -822
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>
> arch/riscv/cpu/generic/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/riscv/cpu/generic/Kconfig b/arch/riscv/cpu/generic/Kconfig
> index 2baba2299238..8d53c69ba38c 100644
> --- a/arch/riscv/cpu/generic/Kconfig
> +++ b/arch/riscv/cpu/generic/Kconfig
> @@ -10,8 +10,8 @@ config GENERIC_RISCV
> imply CPU
> imply CPU_RISCV
> imply RISCV_TIMER if (RISCV_SMODE || SPL_RISCV_SMODE)
> - imply RISCV_ACLINT if RISCV_MMODE
> - imply SPL_RISCV_ACLINT if SPL_RISCV_MMODE
> + imply RISCV_ACLINT if RISCV_MMODE && !TARGET_XILINX_MBV
> + imply SPL_RISCV_ACLINT if SPL_RISCV_MMODE && !TARGET_XILINX_MBV
Would it be a better idea to make (SPL_)RISCV_ACLINT visible and
override them in your platform defconfigs? This avoids introducing
platform-specific conditions in a "generic" CPU Kconfig.
Regards,
Yao Zi
> imply CMD_CPU
> imply SPL_CPU
> imply SPL_OPENSBI
> --
> 2.43.0
>
> base-commit: 0d875f98e9d81b68265ea26c379dae8ce5b1f5a9
next prev parent reply other threads:[~2026-05-01 10:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 11:58 [PATCH] riscv: Exclude ACLINT for TARGET_XILINX_MBV Michal Simek
2026-05-01 10:33 ` Yao Zi [this message]
2026-05-04 9:26 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afSBgg0wWVBn5gju@pie \
--to=me@ziyao.cc \
--cc=git@amd.com \
--cc=michal.simek@amd.com \
--cc=rick@andestech.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.