Re: [PULL 14/42] tests/functional: add a module for handling asset download & caching

["Daniel P. Berrangé" <berrange@redhat.com>]

On Fri, May 01, 2026 at 11:02:48AM +0100, Peter Maydell wrote:
> On Wed, 4 Sept 2024 at 11:41, Thomas Huth <thuth@redhat.com> wrote:
> >
> > From: Daniel P. Berrangé <berrange@redhat.com>
> >
> > The 'Asset' class is a simple module that declares a downloadable
> > asset that can be cached locally. Downloads are stored in the user's
> > home dir at ~/.cache/qemu/download, using a sha256 sum of the URL.
> >
> > [thuth: Drop sha1 support, use hash on file content for naming instead of URL,
> >         add the possibility to specify the cache dir via environment variable]
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > Message-ID: <20240830133841.142644-15-thuth@redhat.com>
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> 
> An old change, but I've just noticed:
> 
> > +        try:
> > +            with tmp_cache_file.open("wb+") as dst:
> > +                copyfileobj(resp, dst)
> > +        except:
> > +            tmp_cache_file.unlink()
> > +            raise
> > +        try:
> > +            # Set these just for informational purposes
> > +            os.setxattr(str(tmp_cache_file), "user.qemu-asset-url",
> > +                        self.url.encode('utf8'))
> > +            os.setxattr(str(tmp_cache_file), "user.qemu-asset-hash",
> > +                        self.hash.encode('utf8'))

snip

> I guess since they're only for "informational purposes" we can
> safely just skip them on non-Linux -- what's the Python way
> to check for "do we have this" ?

  if hasattr(os, "setxattr"):
     ...blah...

With regards,
Daniel