From: Dan Carpenter <error27@gmail.com>
To: Shyam Sunder Reddy Padira <shyamsunderreddypadira@gmail.com>
Cc: Vaibhav Agarwal <vaibhav.sr@gmail.com>,
mgreer@animalcreek.com, johan@kernel.org, elder@kernel.org,
Greg KH <gregkh@linuxfoundation.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: greybus:add missing newline in sysfs show() output
Date: Fri, 1 May 2026 19:53:18 +0300 [thread overview]
Message-ID: <afTafvSmlqsVjUjn@stanley.mountain> (raw)
In-Reply-To: <CALx+fbZ=WyQxinsX+rggvg=rAK32LQuYTFc9c0w7U92e8Uiiww@mail.gmail.com>
On Fri, May 01, 2026 at 10:15:57PM +0530, Shyam Sunder Reddy Padira wrote:
> Hi Dan Carpenter
>
> I have not been able to test this on hardware. I based this change on
> the standard sysfs formatting requirement as documented in
> Documentation/filesystems/sysfs.rst.
> If there is a concern that specific Greybus userspace tools are
> sensitive to the trailing newline, I can withdraw the patch. However,
> this change aligns the driver with the standard sysfs formatting used
> across the kernel.
You need to test it with the Greybus userspace tools, yes.
regards,
dan carpenter
next prev parent reply other threads:[~2026-05-01 16:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 14:42 [PATCH v2] staging: greybus:add missing newline in sysfs show() output Shyam Sunder Reddy Padira
2026-05-01 16:10 ` Dan Carpenter
2026-05-01 16:45 ` Shyam Sunder Reddy Padira
2026-05-01 16:53 ` Dan Carpenter [this message]
2026-05-01 17:09 ` Shyam Sunder Reddy Padira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afTafvSmlqsVjUjn@stanley.mountain \
--to=error27@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mgreer@animalcreek.com \
--cc=shyamsunderreddypadira@gmail.com \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.