From: Brian Norris <briannorris@chromium.org>
To: Titouan Ameline de Cadeville <titouan.ameline@gmail.com>
Cc: jwerner@chromium.org, tzungbi@kernel.org,
chrome-platform@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] coreboot_table: skip failing entries instead of aborting populate
Date: Fri, 1 May 2026 13:54:02 -0700 [thread overview]
Message-ID: <afUS6mMRl36OXC2L@google.com> (raw)
In-Reply-To: <20260501094322.123160-1-titouan.ameline@gmail.com>
On Fri, May 01, 2026 at 11:43:22AM +0200, Titouan Ameline de Cadeville wrote:
> coreboot_table_populate() registers devices one by one. If
> device_register() fails for one entry, the current code returns
> immediately, leaving previously registered devices orphaned on the
> coreboot bus with no cleanup path.
>
> Since coreboot table entries are independent of each other, a failure
> on one entry should not prevent the others from being registered.
> This mirrors the strategy used by of_platform_populate(), which skips
> individual failures rather than aborting.
>
> Move ptr_entry increment before device_register(), log a warning on
> failure, and continue the loop rather than aborting.
>
> Signed-off-by: Titouan Ameline de Cadeville <titouan.ameline@gmail.com>
Acked-by: Brian Norris <briannorris@chromium.org>
next prev parent reply other threads:[~2026-05-01 20:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 9:43 [PATCH v3] coreboot_table: skip failing entries instead of aborting populate Titouan Ameline de Cadeville
2026-05-01 20:54 ` Brian Norris [this message]
2026-05-03 1:42 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afUS6mMRl36OXC2L@google.com \
--to=briannorris@chromium.org \
--cc=chrome-platform@lists.linuxfoundation.org \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=titouan.ameline@gmail.com \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.