All of lore.kernel.org
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: Daniel Palmer <daniel@thingy.jp>
Cc: linux@weissschuh.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] nolibc: Add fallocate()
Date: Sat, 2 May 2026 05:05:11 +0200	[thread overview]
Message-ID: <afVp52csvT3r9giC@1wt.eu> (raw)
In-Reply-To: <20260430164125.1106350-1-daniel@thingy.jp>

On Fri, May 01, 2026 at 01:41:23AM +0900, Daniel Palmer wrote:
> While poking around with my "static PIE for nommu" series I found
> I needed fallocate(). Implementing it turned out a bit more
> interesting than I thought it would be due to how the offset and
> size need to be passed on 32bit machines.
> 
> v3:
>  - Reworked the test a bit, ran it on all the targets I could get
>    to run (s390, loongarch and sh currently don't work for me).
>    sparc32 doesn't seem to support fallocate() so made it skip
>    the test.
>  - Rebase on nolibc/for-next with the large file support bits.
> 
> v2:
>  - Addressed Thomas' comments
>  - Trial and error'd a test for the arguments being passed correctly.
>    Hopefully someone smarter than I am can tell if it actually works.

The series looks good to me, I don't have any particular comment, but
let's wait for Thomas since he's been reviewing it from day one.

Acked-by: Willy Tarreau <w@1wt.eu>

Thanks,
Willy

  parent reply	other threads:[~2026-05-02  3:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-30 16:41 [PATCH v3 0/2] nolibc: Add fallocate() Daniel Palmer
2026-04-30 16:41 ` [PATCH v3 1/2] tools/nolibc: fcntl: " Daniel Palmer
2026-05-01  8:18   ` David Laight
2026-05-02  3:00     ` Willy Tarreau
2026-05-02 21:26       ` David Laight
2026-05-03 16:28         ` Thomas Weißschuh
2026-05-03 22:38           ` David Laight
2026-05-14 11:51             ` Thomas Weißschuh
2026-05-14 21:31               ` David Laight
2026-05-17 15:38                 ` Thomas Weißschuh
2026-04-30 16:41 ` [PATCH v3 2/2] selftests/nolibc: Add a very basic test for fallocate() Daniel Palmer
2026-05-02  3:04   ` Willy Tarreau
2026-05-02  4:00     ` Daniel Palmer
2026-05-02  4:40       ` Willy Tarreau
2026-05-03 16:20   ` Thomas Weißschuh
2026-05-02  3:05 ` Willy Tarreau [this message]
2026-05-03 16:21 ` [PATCH v3 0/2] nolibc: Add fallocate() Thomas Weißschuh
2026-05-04  1:46   ` Daniel Palmer
2026-05-04 15:33     ` Thomas Weißschuh
2026-05-05  2:20       ` Daniel Palmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afVp52csvT3r9giC@1wt.eu \
    --to=w@1wt.eu \
    --cc=daniel@thingy.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@weissschuh.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.