From: Mark Brown <broonie@kernel.org>
To: Richard Acayan <mailingradian@gmail.com>
Cc: Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org,
Nickolay Goppen <setotau@mainlining.org>,
Adam Skladowski <a39.skl@gmail.com>,
Vladimir Lypak <vladimir.lypak@gmail.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Wesley Cheng <quic_wcheng@quicinc.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Johan Hovold <johan@kernel.org>, Kees Cook <kees@kernel.org>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH v4 11/15] ASoC: qcom: sm8250: add support for INT0_MI2S_RX and INT3_MI2S_TX
Date: Sun, 3 May 2026 08:30:04 +0900 [thread overview]
Message-ID: <afaI_FuIq7Pb0kYh@sirena.co.uk> (raw)
In-Reply-To: <20260501153128.8152-12-mailingradian@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 897 bytes --]
On Fri, May 01, 2026 at 11:31:24AM -0400, Richard Acayan wrote:
> The INT0_MI2S_RX and INT3_MI2S_TX ports on SDM660 can be connected to
> the digital and analog WCD codecs. They can be supported with the same
> logic for other ports, but just need to be explicitly stated. Add
> support for these ports.
> + case INT0_MI2S_RX:
> + codec_dai_fmt |= SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_I2S;
> + snd_soc_dai_set_sysclk(cpu_dai,
> + Q6AFE_LPASS_CLK_ID_INT0_MI2S_IBIT,
> + MI2S_BCLK_RATE, SNDRV_PCM_STREAM_PLAYBACK);
> + snd_soc_dai_set_fmt(cpu_dai, fmt);
> + snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
> + break;
> + case INT3_MI2S_TX:
> + codec_dai_fmt |= SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_I2S;
> + snd_soc_dai_set_sysclk(cpu_dai,
> + Q6AFE_LPASS_CLK_ID_INT3_MI2S_IBIT,
> + MI2S_BCLK_RATE, SNDRV_PCM_STREAM_PLAYBACK);
Should these both be using SNDRV_PCM_STREAM_PLAYBACK?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-05-02 23:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 15:31 [PATCH v4 00/15] SDM660 sound card and internal MI2S support Richard Acayan
2026-05-01 15:31 ` [PATCH v4 01/15] ASoC: dt-bindings: qcom,sm8250: add compatible for sdm660 Richard Acayan
2026-05-03 12:08 ` Krzysztof Kozlowski
2026-05-01 15:31 ` [PATCH v4 02/15] ASoC: dt-bindings: qcom: q6dsp: add internal mi2s support Richard Acayan
2026-05-03 12:11 ` Krzysztof Kozlowski
2026-05-03 21:21 ` Richard Acayan
2026-05-14 13:55 ` Krzysztof Kozlowski
2026-05-01 15:31 ` [PATCH v4 03/15] ASoC: dt-bindings: pm8916-wcd-analog-codec: Document pm8950/pm8953 Richard Acayan
2026-05-03 12:10 ` Krzysztof Kozlowski
2026-05-01 15:31 ` [PATCH v4 04/15] ASoC: dt-bindings: pm8916-analog-codec: Add PM660L compatible Richard Acayan
2026-05-03 21:22 ` Richard Acayan
2026-05-01 15:31 ` [PATCH v4 05/15] ASoC: dt-bindings: msm8916-digital-codec: Add SDM660 compatible Richard Acayan
2026-05-01 15:31 ` [PATCH v4 06/15] ASoC: qdsp6: q6dsp-lpass-ports: add internal mi2s support Richard Acayan
2026-05-03 12:12 ` Krzysztof Kozlowski
2026-05-01 15:31 ` [PATCH v4 07/15] ASoC: qdsp6: q6afe: " Richard Acayan
2026-05-01 15:31 ` [PATCH v4 08/15] ASoC: qdsp6: q6afe-dai: " Richard Acayan
2026-05-02 23:28 ` Mark Brown
2026-05-03 21:35 ` Richard Acayan
2026-05-01 15:31 ` [PATCH v4 09/15] ASoC: qdsp6: q6routing: " Richard Acayan
2026-05-01 15:31 ` [PATCH v4 10/15] ASoC: qdsp6: common: support headphone jacks connected to internal mi2s Richard Acayan
2026-05-01 15:31 ` [PATCH v4 11/15] ASoC: qcom: sm8250: add support for INT0_MI2S_RX and INT3_MI2S_TX Richard Acayan
2026-05-02 23:30 ` Mark Brown [this message]
2026-05-01 15:31 ` [PATCH v4 12/15] ASoC: qcom: sm8250: add SDM660 compatible Richard Acayan
2026-05-01 15:31 ` [PATCH v4 13/15] ASoC: msm8916-wcd-analog: add pm8950 codec Richard Acayan
2026-05-01 15:31 ` [PATCH v4 14/15] ASoC: msm8916-wcd-analog: add pm8953 codec Richard Acayan
2026-05-01 15:31 ` [PATCH v4 15/15] ASoC: msm8916-wcd-analog: add quirk for cajon 2.0 Richard Acayan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afaI_FuIq7Pb0kYh@sirena.co.uk \
--to=broonie@kernel.org \
--cc=a39.skl@gmail.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=kees@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mailingradian@gmail.com \
--cc=mohammad.rafi.shaik@oss.qualcomm.com \
--cc=perex@perex.cz \
--cc=quic_wcheng@quicinc.com \
--cc=robh@kernel.org \
--cc=setotau@mainlining.org \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
--cc=vladimir.lypak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.